Bug #46216 License header size differences again
Submitted: 16 Jul 2009 10:03 Modified: 20 Oct 2009 20:22
Reporter: Hartmut Holzgraefe Email Updates:
Status: Closed Impact on me:
Category:MySQL Server: Packaging Severity:S3 (Non-critical)
Version:mysql-5.0.84, mysql-5.1.36, others OS:Any
Assigned to: Joerg Bruehe CPU Architecture:Any

[16 Jul 2009 10:03] Hartmut Holzgraefe
The GPL and commercial license headers have different sizes again so that error log backtrace, core dump and cluster trace file line numbers may be off by +/-1
when checking against the wrong licensed version of the source ...

How to repeat:
Check headers of files from mysql-... source packages against mysqlcom-... source packages of the same release

Suggested fix:
Make sure both license headers have the same line count
[16 Jul 2009 10:06] Hartmut Holzgraefe
Triage reasoning:

D4 - does only affect post mortem analysis of crashes but does not cause any
W3 - usually it is clear whether the actual culprit is the actual line or the one above or below, but not always
I4 - does not really affect any customers but 'only' ourselves internally
[6 Oct 2009 18:06] Joerg Bruehe
Checked in the sources of 5.0.86 and 5.1.39:

The text in the commercial files that replaces the GPL text is one line too long.
[19 Oct 2009 19:37] Joerg Bruehe
Bug fix is pushed into the current tools,
to be used for all versions from 5.0.88, 5.1.41, 5.4.5-beta and up.

It is a tool fix only, and GPL (including community) builds are not affected.

However, for some customers using our commercial sources it might be interesting to know that in previous builds the source line numbers for some files may differ by 1 from the GPL sources.
[20 Oct 2009 20:22] Paul DuBois
Noted in 5.0.88, 5.1.41, 5.5.0 changelogs.

The GPL and commercial license headers had different sizes, so that
error log, backtrace, core dump, and cluster trace file line numbers
could be off by one if they were not checked against the version of
the source used for the build. (For example, checking a GPL build
backtrace against commercial sources.)