MySQL Bugs: #46066: QUAN Statement Popup Graph Clean Up

Bug #46066	QUAN Statement Popup Graph Clean Up
Submitted:	8 Jul 2009 22:26	Modified:	7 Aug 2009 13:23
Reporter:	Mark Leith	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Enterprise Monitor: Web	Severity:	S3 (Non-critical)
Version:		OS:	Any
Assigned to:	Eric Herman	CPU Architecture:	Any

Description:
Currently, the QUAN statement popup's history graphs are inconsistent with the other graphs:

o Their series colors are different
o They right align the graph image, but left align the title, so when you "expand" the popup, you get an ugly big space on the left if the browser window is fairly large
o The series names do not need to have things like "Avg Rows" - "row count" should be in the y series label, leaving the series names as "avg, min, max" 

How to repeat:
N/A

Suggested fix:
o Sync up the colors with the standard graphs
o Move the series to the right, or below the graph images
o Left align the images
o Remove the text after Avg for each series
o Add a y label?

Eric Herman writes: 
The Quan graph pop-ups now use the same graph rendering as the rest of the graphs in the system.

Additionally:
 * The legend keys are localized and match the rest of the the graphs for Min, Max, and Average
      (Min, Max, Average are now localized in regular graphs, too.)
 * The Y axis now has a Range Label where appropriate
 * The colors are now consistent with the rest of graphing
 * The more consistent legend keys make for more consistent alignment of graphs

Not Going To Fix:
 * The legend remains on the left, per discussion with jsled and Leith on IRC

Remaining: Graph Alignment
 * The begining of the graphs do not perfectly align 
 * Today we set the dimensions for the entire image, including the legend.
 * To align differently may need to consider one of:
       * specify the size of the plot area
       * make the legends the same size
       * move the legends below

(more research is needed)

Keith Russell writes: 
Patch installed in versions => 2.1.0.1082.

Eric Herman writes: 
* Removed the old code behind the if(true/false) switch;

* Added a new property which we may elect to expose to tune when graphs force the Y axis to be just integers.

If the maximum value on the Y axis is small, then we see values like 0.1, 0.2, 0.3 ... if it is large we just see integers.

    GRAPH_FRACTIONS_CUTOFF = "graph.fraction.cutoff";
    GRAPH_FRACTIONS_CUTOFF_DEFAULT = 2.0;

Marcos Palacios writes: 
Verified fixed in service manager build 2.1.0.1085.

Marcos Palacios writes: 
Changing the Fix Version to the actual one.

An entry was added to the 2.1.0 changelog:

The Query Analyzer Statement Popup history graphs were inconsistent with the other graphs. In particular:

The series colors were not consistent with other graphs.

The graph image was right aligned, but the title was left aligned. When the popup was expanded, unecessary space was located on the left.

The Y axis did not have a Range Label.