Bug #45655 Agent upgrade installer overwrites agent-item-files in mysql-monitor-agent.ini
Submitted: 22 Jun 2009 13:55 Modified: 27 Jul 2009 16:36
Reporter: Mark Leith Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Enterprise Monitor: Installing Severity:S3 (Non-critical)
Version:2.1.0.1045 OS:Any
Assigned to: BitRock Merlin CPU Architecture:Any
Tags: MEM agent, upgrade

[22 Jun 2009 13:55] Mark Leith 
Description:
If you create custom collection files for the agent, and add these to the agent-item-files variable within the mysql-monitor-agent.ini file, on upgrade we:

1) Overwrite the agent-item-files variable on upgrade (removing the custom entry)
2) Blow away the custom files, if they are included under the share/ directory

How to repeat:
o Do the following:

cd /path/to/agent/install
cd share
mkdir custom
cd custom
vim cumstom.xml

o Add this:

<classes>
        <class>
                <namespace>mysql</namespace>
                <classname>mysql_version</classname>
                <query><![CDATA[SELECT VERSION()]]></query>
        </class>
</classes>

o Modify mysql-monitor-agent.ini:

agent-item-files = share/mysql-proxy/items/quan.lua,share/mysql-proxy/items/items-mysql-monitor.xml,share/mysql-proxy/items/agent-allocation-stats.lua,share/custom/custom.xml

o Restart, make sure the custom collection works
o Upgrade the agent
o Check for the files, or reference in the mysql-monitor-agent.ini file

Suggested fix:
1) Do not overwrite agent-item-files on upgrade
2) Do not remove custom directories/files in the share/ directory
[25 Jun 2009 15:07] BitRock Merlin 
Patch sent to Keith
[6 Jul 2009 22:03] Enterprise Tools JIRA Robot 
Keith Russell writes: 
Patch applied in versions => 2.1.0.1074.
[21 Jul 2009 22:42] Enterprise Tools JIRA Robot 
Marcos Palacios writes: 
Verified fixed in agent update installer build 2.1.0.1078.
[27 Jul 2009 16:36] Tony Bedford 
An entry was added to the 2.1.0 changelog:

If custom collection files were created for the Agent, and references added to the agent-item-files variable within the mysql-monitor-agent.ini file, on upgrade the following problems occurred:

1. The agent-item-files variable was overwritten, thereby removing the custom entry.

2. The custom files were deleted, if they were contained in the share/ directory.