Bug #45045 Patch: advanced search rows per page should default to APP_DEFAULT_PAGER_SIZE

• Submitted: 23 May 2009 10:58
• Modified: 23 Jun 2009 22:26
• Reporter: Robbert-Jan Roos
• Status: Closed
• Category: Eventum
• Severity: S3 (Non-critical)
• Version: All
• OS: Any
• CPU Architecture: Any
• Tags: Contribution

[23 May 2009 10:58] Robbert-Jan Roos

Description:
eventum -> advanced search
The 'rows per page' select box always shows 5. It should default to APP_DEFAULT_PAGER_SIZE

How to repeat:
navigate to eventum -> advanced search

Suggested fix:
http://lists.mysql.com/eventum-users/5419

patch against current trunk (rev 3880)

->svn diff adv_search.php
Index: adv_search.php
===================================================================
--- adv_search.php      (revision 3880)
+++ adv_search.php      (working copy)
@@ -80,7 +80,11 @@
             $check_perm = false;
         }
     }
-    $tpl->assign("options", Filter::getDetails($_GET["custom_id"], $check_perm));
+    $options = Filter::getDetails($_GET["custom_id"], $check_perm);
+} else {
+    $options = array();
+    $options["cst_rows"] = APP_DEFAULT_PAGER_SIZE;
 }
+$tpl->assign("options", $options);

 $tpl->displayTemplate();

[23 May 2009 11:29] Robbert-Jan Roos

severity S4 won't show when using bugs.mysql.com and not changing severity.
Changing to S3 so the patch gets applied sooner (hopefully)

[23 Jun 2009 22:26] Bryan Alsdorf

Merged into bzr

http://bazaar.launchpad.net/~eventum-developers/eventum/trunk/revision/3848

Thanks for the patch!