MySQL Bugs: #45030: PB2 Legend mising information

Bug #45030	PB2 Legend mising information
Submitted:	22 May 2009 9:49	Modified:	28 Sep 2009 10:21
Reporter:	Ingo Strüwing	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Tools: Pushbuild	Severity:	S3 (Non-critical)
Version:		OS:	Any
Assigned to:	Daniel Fischer	CPU Architecture:	Any

Description:
The Legend on the Pushbuild branch pages shall have answers for the following questions:

1. What do the sub-cells in the main cells stand for?
For example there is often a small light green cell near the top of a pink
cell. It contains two icons, which seems to be a tarchive of the built tree
and a build log. So one might try to guess, what is stands for, but still
the question is, why does it have a different color than the main cell?
If it is intended to say that the build was successful, why don't have
successful test lines the same background, and just the failing ones pink?
Also, sometimes warnings have a small sub-cell, sometimes they fill the rest
of the cell. Clicking on the icon reveals compiler warnings. Why do these
appear past the tests? I'd expect them to occure during the build and thus
before the tests. All this shall be explained in the legend.

2. Why are the sub-cells sometimes present, and sometimes missing?
For example, the "build" cell is not present for Gcov and Valgind builds.
Sometimes "test" and/or "warnings" cells are missing.

3. Why is there a red zero in test lines like funcs_2 0/0? In other words,
under which circumstances can it be a failure when zero tests fail?

4. How can an expanded view be collapsed after expanding it with a click on
a test result blob?

5. What do the buttons in the expanded view do in real? The existing legend
has some information on them. But clicking on them doesn't seem to do the
promised action. The buttons change their color. That's it.

6. Why do we need another set of links in the expanded view? They seem to be
the same as the icons below the expanded view. This is confusing. Please
explain, why this is required.

7. What is the difference between the tar archives behind the icons on top
and bottom of the cell? Does the later include the former?

8. What does "exp-fail" mean?

How to repeat:
Look at a pushbuild branch page and try to understand it in detail.

Suggested fix:
I expect this bug report to be seen as a minor issue and thus not solved in a foreseeable future. The knowledge will finally spread among the developers after some dozen have raised the same questions repeatedly. Therafter it will get even lower priority.

Please do me the favor to add the explanations as a comment to this bug report or in the Wiki as soon as possible, so that the information is available at some place at least.

I amended the legend. Can you please verify that the added text clears up items 1, to 4, 7 and 8?

Additional notes:

2) I didn't specifically mention valgrind. The reason there is only one cell is that it is a test run that is performed with binaries from the regular linux builds in a different column. We will soon start building specific binaries for valgrind with HAVE_purify defined, so this will eventually look the same as most other build/test pairs.

5) The buttons do exactly what the legend says they do. Due to a server-side cache, visual changes may take few minutes to become visible. This was already explained in the legend (last item).

6) These links were requested by users.

Forgot one note:

8) exp-fail and experimental is the result of bug#42888.

Thank you very much for the explanations and the extended legend. Most of my questions are answered now. However, I'm still not sure about:

- In the legend you write: "... an inset yellow cell inside a red cell
  describes a step that did not fail, but produced warnings or a warning
  condition." But most such "steps" contain compiler warnings only. So
  what extra step is done here, besides of the build, which is shown on
  top of the cell? (This information might be beyond a legend
  information though.)

- What is the difference between the tar archives behind the icons on
  top (the one without -test in their names) and bottom of the cell
  (the one with -test in their names)? Does the later include the former?
  [Was this information planned to go behind the empty bullet in the
   legend?]

There is another small piece of information missing:

What does it mean if a cell contains buld and warning info only? No test sub-cell, and no "in progress" sub-cell?

See for example mysql-6.0-backup. On macosx10.5 we either have pink test sub-cells, or no test sub-cell at all.

So, does a missing test sub-cell mean that the tests succeeded?

But OTOH there are cells, where the test sub-cells appear in light green, indicating success. So this is a little confusing. Please add an explanation to the legend.

I added explanations for these three cases to the legend.