Bug #44936 ndb_restore - printout of --progress-frequency is not complete

• Submitted: 18 May 2009 16:35
• Modified: 21 May 2009 7:52
• Reporter: Johan Andersson
• Status: Verified
• Category: MySQL Cluster: Cluster (NDB) storage engine
• Severity: S4 (Feature request)
• Version: mysql-5.1-telco-7.0
• OS: Any
• CPU Architecture: Any
• Tags: -6.2), (-6.3, ndb_restore

[18 May 2009 16:35] Johan Andersson

Description:
ndb_restore --progress-frequency=1 
prints out
"Data file progress: %d bytes"
But it would be great to know .. out of how much!
"Data file progress: %d bytes out of %d bytes (x percent complete)"

Then the progress-frequency would be useful.

How to repeat:
Run ndb_restore with --progress-frequency=1

Suggested fix:
add the missing printout

[23 Jan 2010 8:32] Andrew Hutchings

This should already exist if the file size is obtainable:

static void report_progress(const char *prefix, const BackupFile &f)
{
  info.setLevel(255);
  if (f.get_file_size())
    info << prefix << (f.get_file_pos() * 100 + f.get_file_size()-1) / f.get_file_size()
         << "%(" << f.get_file_pos() << " bytes)\n";
  else
    info << prefix << f.get_file_pos() << " bytes\n";
}