MySQL Bugs: #43894: MTR's --replace-result failing for $MASTER

Bug #43894	MTR's --replace-result failing for $MASTER_MYSOCK on Windows PB2 hosts
Submitted:	26 Mar 2009 18:35	Modified:	14 May 2009 16:19
Reporter:	Patrick Crews	Email Updates:
Status:	Duplicate	Impact on me:	None
Category:	Tools: MTR / mysql-test-run	Severity:	S3 (Non-critical)
Version:	5.0 and up, incl CGE	OS:	Windows
Assigned to:	Assigned Account	CPU Architecture:	Any
Tags:	master_mysock, mysql-test-run, path names, windows

Description:
mysql-test-run's --replace-result is failing for $MASTER_MYSOCK on PB2's Windows hosts:

Failing the test(s): connect grant mysqltest openssl_1

They all fail in the same manner:
-connect(localhost,ssl_user5,,test,MASTER_PORT,MASTER_SOCKET);
+connect(localhost,ssl_user5,,test,MASTER_PORT,C:\Users\bteam\AppData\Local\Temp\2\uGupuD1yml/master.sock);

I haven't had a chance to dig too deeply into the root cause, but the path for MASTER_MYSOCK appears to be off - note / vs. \ in the path.

Output from:  http://loki41.norway.sun.com/~bteam/pb2/web_loki41.py?action=archive_download&archive_id=4...

grant, co

openssl_1                      [ fail ]

--- G:/pb2/test/sb_1-425011-1238007722.03/mysql-5.0.80-win-x86_64-test/mysql-test/r/openssl_1.result	2009-03-25 21:33:35.000000000 +0300
+++ G:\pb2\test\sb_1-425011-1238007722.03\mysql-5.0.80-win-x86_64-test\mysql-test\r\openssl_1.reject	2009-03-25 22:14:54.958228400 +0300
@@ -7,7 +7,7 @@
 grant select on test.* to ssl_user4@localhost require cipher "DHE-RSA-AES256-SHA" AND SUBJECT "/C=SE/ST=Uppsala/O=MySQL AB/emailAddress=abstract.mysql.developer@mysql.com" ISSUER "/C=SE/ST=Uppsala/L=Uppsala/O=MySQL AB";
 grant select on test.* to ssl_user5@localhost require cipher "DHE-RSA-AES256-SHA" AND SUBJECT "xxx";
 flush privileges;
-connect(localhost,ssl_user5,,test,MASTER_PORT,MASTER_SOCKET);
+connect(localhost,ssl_user5,,test,MASTER_PORT,C:\Users\bteam\AppData\Local\Temp\2\uGupuD1yml/master.sock);
 ERROR 28000: Access denied for user 'ssl_user5'@'localhost' (using password: NO)
 SHOW STATUS LIKE 'Ssl_cipher';
 Variable_name	Value

How to repeat:
I haven't been able to repeat this on my own Windows machines, but it happens on a regular basis on Pushbuild2:

http://loki41.norway.sun.com/~bteam/pb2/web_loki41.py?action=archive_download&archive_id=4...

This occurs on both the normal and ps-protocol runs.

Suggested fix:
Look into how the path for MASTER_MYSOCK is handled on Windows - if I recall, there is some 'path-voodoo' that occurs in MTR's code.  Perhaps the case of longer path names is an issue.

Regardless, MTR needs to be able to recognize $MASTER_MYSOCK when presented with it.

This might be somehow related to:
Bug#36041	mysql-test-run doesn't seem to string match 100% effectively on Windows

NOTE:  I just determined that this occurs with longer path names.

C:/work/mysql-5.0-bugteam worked without issue

C:/work/this_should_be_a_very_long_path_name/... resulted in a repeat of the failures seen on PB2

Same issue in the release build of cluster-7.0.5, affecting these tests:
funcs_1.ndb_storedproc_06
funcs_1.ndb_storedproc_10
funcs_1.ndb_trig_03
funcs_1.ndb_trig_03e
funcs_1.ndb_trig_0407

I will handle this, bug #44871

Duplicate of bug 44871.