Bug #43773 Monitor upgrade installer overwrites the AdvisorScript.jar with the default one
Submitted: 20 Mar 2009 22:57 Modified: 22 May 2009 8:38
Reporter: Marcos Palacios Email Updates:
Status: Closed Impact on me:
Category:MySQL Enterprise Monitor: Installing Severity:S2 (Serious)
Version: OS:Any
Assigned to: BitRock Merlin CPU Architecture:Any

[20 Mar 2009 22:57] Marcos Palacios
The monitor upgrade installer overwrites the AdvisorScript.jar in <instDir>/apache-tomcat/webapps/ROOT/WEB-INF/lib/ with the default one. This is not correct because that's where we store the advisors that the customer uploaded.

We observed this behavior by checking the size of the AdvisorScript.jar file before the upgrade, right after the upgrade (without an import of the new advisor file), and after the import of the new file:

before the upgrade (file is ver.       270,813 bytes
right after the upgrade (file is the default ver.):  48,189 bytes
after the advisor import (file is ver. 271,705 bytes

How to repeat:
- install MEM 2.0.5
- upgrade MEM to 2.1.0
- observe how the advisor rules and graphs don't have their names correctly translated (from the internal labels) in the Advisors and Graphs tabs

Suggested fix:
Copy the same AdvisorScript.jar file that the installation had before the update.
[20 Mar 2009 23:37] Josh Sled
This is going to break the translations of every customer who uses the upgrader.

I believe this is true for 2.0.x, as well.

Raising Severity.
[24 Mar 2009 14:50] BitRock Merlin
Patch sent to Keith.
[25 Mar 2009 17:57] Marcos Palacios
Verified fixed in build
[25 Mar 2009 19:34] Keith Russell
Patch installed in versions =>
[26 Mar 2009 0:44] Marcos Palacios
Verified fixed in build
[22 May 2009 8:38] Tony Bedford
An entry was added to both the 2.0.6 and 2.1.0 changelogs:

The MySQL Enterprise Monitor upgrade installer incorrectly replaced the AdvisorScript.jar in <instDir>/apache-tomcat/webapps/ROOT/WEB-INF/lib/ with the default Advisor JAR.