Bug #43586 mysql_upgrade summary would be helpful

• Submitted: 12 Mar 2009 11:43
• Reporter: Johan Idrén
• Status: Verified
• Category: MySQL Server: Installing
• Severity: S4 (Feature request)
• Version: 5.1.31
• OS: Any
• Assigned to: Daniel Fischer
• CPU Architecture: Any

[12 Mar 2009 11:43] Johan Idrén

Description:
After running mysql_upgrade, it can be unclear what actions you are requested to take.
Especially if you haven't read the manual.

How to repeat:
shell> mysql_upgrade
Looking for 'mysql' as: mysql
Looking for 'mysqlcheck' as: mysqlcheck
Running 'mysqlcheck'...
Running 'mysqlcheck'...
mysql.columns_priv                                 OK
mysql.db                                           OK
mysql.event                                        OK
mysql.func                                         OK
mysql.general_log
Error    : You can't use locks with log tables.
status   : OK
mysql.help_category
error    : Table upgrade required. Please do "REPAIR TABLE `help_category`" to fix it!
mysql.help_keyword
error    : Table upgrade required. Please do "REPAIR TABLE `help_keyword`" to fix it!
mysql.help_relation                                OK
mysql.help_topic
error    : Table upgrade required. Please do "REPAIR TABLE `help_topic`" to fix it!
mysql.host                                         OK
mysql.ndb_binlog_index                             OK
mysql.plugin                                       OK
mysql.proc
error    : Table upgrade required. Please do "REPAIR TABLE `proc`" to fix it!
mysql.procs_priv                                   OK
mysql.servers                                      OK
mysql.slow_log
Error    : You can't use locks with log tables.
status   : OK
mysql.tables_priv                                  OK
mysql.time_zone                                    OK
mysql.time_zone_leap_second                        OK
mysql.time_zone_name
error    : Table upgrade required. Please do "REPAIR TABLE `time_zone_name`" to fix it!
mysql.time_zone_transition                         OK
mysql.time_zone_transition_type                    OK
mysql.user                                         OK

Repairing tables
mysql.help_category                                OK
mysql.help_keyword                                 OK
mysql.help_topic                                   OK
mysql.proc                                         OK
mysql.time_zone_name                               OK
Running 'mysql_fix_privilege_tables'...
OK

Here it states that you need to REPAIR TABLE, but mysql_upgrade does that for you. 
You also need to restart the server, while noted in the documentation it could be mentioned here as well.

Suggested fix:
It would be useful to get a short but clear summary at the end of the mysql_upgrade process.
Something like "Upgrade successfull. All tables needing REPAIR are repaired. Please restart the server."

Or

"Upgrade successful. No further action needed."
etc etc