Bug #37473 bzr commit mail can not find the target bug page
Submitted: 18 Jun 2008 10:00 Modified: 18 Jun 2008 11:08
Reporter: Andrei Elkin Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Websites: bugs.mysql.com Severity:S3 (Non-critical)
Version: OS:Any
Assigned to: Andrei Elkin CPU Architecture:Any
Tags: bzr-mysql-plugin

[18 Jun 2008 10:00] Andrei Elkin
Description:
1. the bug id pattern is incorrect. E.g a pattern like 'bug 123' is  recognized;
2. the first recognized bug id is defined as the target bug id so that the  commit mail lands on that page. This does not hold currently.

Some developers complain about it. Examples of misplaced commits can be found on bug db. E.g
  http://lists.mysql.com/commits/47588 
should belong to   BUG#36586, instead it's wrong home appeared to be Bug #36624.

How to repeat:
compose comments of bzr gcommit with 1. referring incorrect pattern and 2. referring to a bug which number is less than the target one.

Suggested fix:
changes compatible to $bk_tree_root/BitKeeper/triggers/post-commit in /bzrroot/bzr-plugins/mysql/emailer.py are needed.
[18 Jun 2008 10:25] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48065
[18 Jun 2008 10:40] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48068
[18 Jun 2008 10:45] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48070
[18 Jun 2008 10:54] Andrei Elkin
Pushed to bzr+ssh://bk-internal.mysql.com/bzrroot/bzr-plugins/mysql
[18 Jun 2008 11:08] Andrei Elkin
this is a quote on convention on the change set composing
ChangeSet 1.1616.2852.5 2006/11/12 13:38:13 aelkin@dsl-hkibras-fe30f900-107.dhcp.inet.fi:

The targetted BUG's or WL's identifier must be specified
the first in the comments. The referred bugs wls can be typed in same as the targeted clickable format.
If the the target of the fix is a WL and there are some references to bugs
then the first found reference is regarded as "co-target" so that the bug's identifier comes up on the subject line along with the WL's and commit mail will update the bug page.
The latter feature can be disarmed (if there is no need to update
referred bugs pages) with typing the first a pseudo-bug pattern (bug#0).
[18 Jun 2008 11:13] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/48073