MySQL Bugs: #35917: 'expand all' button is on when all graphs are already expanded

Bug #35917	'expand all' button is on when all graphs are already expanded
Submitted:	8 Apr 2008 23:02	Modified:	14 Oct 2008 16:48
Reporter:	Marcos Palacios	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Enterprise Monitor: Web	Severity:	S3 (Non-critical)
Version:	2.0.0.6008	OS:	Any
Assigned to:	Josh Sled	CPU Architecture:	Any

Description:
On the Graphs page, if we expand all graphs, then update the Time Display interval, it refreshes the page with the 'expand all' button on, eventhough all the graphs are already expanded.

The workaround is to just click on the button again.

How to repeat:
See Description above.

After looking at other ways to reproduce it, here is another and my conclusion below.
  This will happen also if we switch to a different server on the left tree while on the Graphs page with all expanded.
  It seems the reason for the issue is that the Graphs page always refreshes with the button in 'expand all' mode.

This is trickier than it may appear at first glance - maybe taking 3 or 4 hours. Unless the priority goes up I'll put this at the bottom of my list of things to do prior to release.

Notes about implementation:

If a graph being open or closed was dependent on what was selected on the tree nav, I would say not to implement. However, since it's not, you can implement by having a page specific cookie to record last known state and updating the button at the same time you do row expansion. This may be something you can add generically to rowDisplayToggle.js but you need to check if anything else using that class would need the same behavior.

revno: 6238
revision-id: jsled@asynchronous.org-20080829002428-j2za5z3k6kgnvbt1
parent: jsled@asynchronous.org-20080828215737-e49s62pju0j337qe
committer: Josh Sled <jsled@asynchronous.org>
branch nick: local
timestamp: Thu 2008-08-28 20:24:28 -0400
message:
  Bug#35917: keep track of how many unexpanded rows there are, decrement while doing client-side cookie-based expansion, then check to see if we need to flip the label at the end of page-load time.

Verified fixed in build 2.0.0.7042.

An entry was added to the 2.0 changelog:

On the Graphs page, if all graphs were expanded, then the Time Display interval updated, the page was refreshed with the Expand All button displayed, even though all the graphs were already expanded.