Bug #35553 mysql libs patch
Submitted: 25 Mar 2008 13:48 Modified: 12 Apr 2013 13:19
Reporter: Elan Ruusamäe (OCA) Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Packaging Severity:S3 (Non-critical)
Version:6.0, 5.1, 5.0, 4.1, 4.0 OS:Any
Assigned to: Hery Ramilison CPU Architecture:Any
Tags: Contribution

[25 Mar 2008 13:48] Elan Ruusamäe
Description:
hi

i would like you to review and accept mysql-libs.patch from http://www.pld-linux.org/

the changes are:
- don't link with unnecessary -lnsl
- link with -lcrypt only where needed
- link libmysqlclient_r with -lpthread

i'm currently testing if the -lpthread can be replaced with @LIBS@ instead.

for 6.0: http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/mysql-libs.patch?rev=1.19.2.1;content-...

for 5.1:
http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/mysql-libs.patch?rev=1.19;content-type...

for 5.0:
http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/mysql-libs.patch?rev=1.14.2.4;content-...

for 4.1:
http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/mysql-libs.patch?rev=1.10.2.1.2.1;cont...

for 4.0:
http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/mysql-libs.patch?rev=1.8;content-type=...

How to repeat:
there's nothing to repeat, it's optimization :)
[25 Mar 2008 15:12] Susanne Ebrecht
Many thanks for writing a feature request.

Please consider that MySQL has to run with all possible Unix platforms and Windows.
[26 Mar 2008 13:45] Elan Ruusamäe
i believe it is not breaking the OS compat, as there's fallback to previous checks.

also the -lpthread patch looks no longer neccessary -lpthread already in @LIBS@
[28 Mar 2008 8:44] Sergei Golubchik
-lpthread is wrong. This option is different on different systems (e.g. it was -pthread on older FreeBSD), we cannot use "-lpthread" unconditionally.

-lnsl and -lcrypt should be ok
[28 Mar 2008 11:41] Elan Ruusamäe
updated for 5.1:
http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/mysql-libs.patch?rev=1.21;content-type...

updated for 5.0:
http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/mysql-libs.patch?rev=1.14.2.5;content-...
[8 Jun 2009 23:13] liz drachnik
Hello Elan - 

In order for us to continue the process of reviewing your contribution to MySQL - We need you to review and sign the Sun|MySQL contributor agreement (the "SCA")

The process is explained here: 
http://forge.mysql.com/wiki/Sun_Contributor_Agreement

Getting a signed/approved SCA on file will help us facilitate your contribution-- this one, and others in the future.

Thank you ! 

Liz Drachnik  - Program Manager - MySQL
[12 Apr 2013 13:19] Yngve Svendsen
Dear Elan,

since we did not receive a response as to whether you would be willing to formally license this patch to us, we were prevented from proceeding at the time. 

Now, it has been a while, and MySQL has developed quite a bit in the meantime. If you feel that the contribution would still be relevant for recent versions of MySQL, and you are willing to sign an Oracle Contributors agreement, please let us know, and we can proceed to a point where we can evaluate the actual contribution.

In the meantime, I am closing this, but if you respond, the ticket will automatically get reopened.
[12 Apr 2013 13:19] Yngve Svendsen
Dear Elan,

since we did not receive a response as to whether you would be willing to formally license this patch to us, we were prevented from proceeding at the time. 

Now, it has been a while, and MySQL has developed quite a bit in the meantime. If you feel that the contribution would still be relevant for recent versions of MySQL, and you are willing to sign an Oracle Contributors agreement, please let us know, and we can proceed to a point where we can evaluate the actual contribution.

In the meantime, I am closing this, but if you respond, the ticket will automatically get reopened.