Bug #34239 Server: Thread pool options are obsolete or badly described

• Submitted: 1 Feb 2008 18:39
• Modified: 28 Jun 2011 16:24
• Reporter: Paul DuBois
• Status: Can't repeat
• Category: MySQL Server: General
• Severity: S3 (Non-critical)
• Version: 6.0.4
• OS: Any
• CPU Architecture: Any

[1 Feb 2008 18:39] Paul DuBois

Description:
In sql/mysqld.cc, the --pool-of-threads option structure looks like this:

  {"pool-of-threads", OPT_POOL_OF_THREADS,
   "Use pool of threads during testing. NOTE: Use
thread-handling=pool-of-threads instead",
   0, 0, 0, GET_NO_ARG, NO_ARG, 0, 0, 0, 0, 0, 0},

I'm unsure what to make of that. It seems to indicate that this
option has the following properties:
- Only for testing (Is that true? Testing *what*?)
- Shouldn't be used anyway, per the NOTE (Is that true? Why have it, then?)

* Kostja says this option should be removed

The --one-thread option structure looks like this:

  {"one-thread", OPT_ONE_THREAD,
   "(deprecated): Only use one thread (for debugging under Linux). Use
thread-handling=no-threads instead",
   0, 0, 0, GET_NO_ARG, NO_ARG, 0, 0, 0, 0, 0, 0},

It would be better for the message to say "Use --thread_handling"
than to say "Use thread-handling" (That is, include leading dashes, change
the dash in the variable name to an underscore).

Also, the entry for thread_handling in the option structure is out
of order. It follows transaction_prealloc_size, it should follow
thread_concurrency.

How to repeat:
See above.