Bug #33330 Test code leaves procedure 'test_multi_sets'
Submitted: 18 Dec 2007 11:14 Modified: 2 Oct 2009 19:05
Reporter: Henri de Veer Email Updates:
Status: No Feedback Impact on me:
None 
Category:Connectors: DBD::mysql ( Perl ) Severity:S3 (Non-critical)
Version:DBD-mysql-4.005 OS:Solaris (5.8)
Assigned to: CPU Architecture:Any
Tags: Contribution, TESTCODE

[18 Dec 2007 11:14] Henri de Veer
Description:
When running the test suite a stored procedure is left over in the test database.

The testcode should leave the database in the initial state.

This is a minor cosmetic problem.

DBD-mysql-4.005
DBI-1.601
mysql-5.0.51

How to repeat:
Run the testsuite and query the database with:

SHOW PROCEDURE STATUS;

It shows the left over test procedure:

sdev_p | test_multi_sets | PROCEDURE | hveer@% | 2007-12-18 09:56:17 | 2007-12-18 09:56:17 | DEFINER

Suggested fix:
Drop the procedure after testing with:

DROP PROCEDURE test_multi_sets;

Patch to apply:

*** DBD-mysql-4.005/t/80procs.t Fri Jun  8 15:06:15 2007
--- 80procs.t   Tue Dec 18 11:45:02 2007
***************
*** 188,193 ****
--- 188,196 ----
    Test($state or !($more_results =  $sth->more_results())) or
      DbiError($dbh->err, $dbh->errstr);
  
+   Test($state or $dbh->do("DROP PROCEDURE IF EXISTS test_multi_sets")) or
+     DbiError($dbh->err, $dbh->errstr);
+ 
    local $SIG{__WARN__} = sub { die @_ };
  
    Test($state or $dbh->disconnect()) or
[18 Dec 2007 11:50] Valeriy Kravchuk
Thank you for a bug report and patch contributed.
[8 Jun 2009 22:53] liz drachnik
Hello Henri - 

In order for us to continue the process of reviewing your contribution to MySQL - We need you to review and sign the Sun|MySQL contributor agreement (the "SCA")

The process is explained here: 
http://forge.mysql.com/wiki/Sun_Contributor_Agreement

Getting a signed/approved SCA on file will help us facilitate your contribution-- this one, and others in the future.

Thank you ! 

Liz Drachnik  - Program Manager - MySQL
[2 Oct 2009 23:00] Bugs System
No feedback was provided for this bug for over a month, so it is
being suspended automatically. If you are able to provide the
information that was originally requested, please do so and change
the status of the bug back to "Open".