MySQL Bugs: #31143: mysqlslap.exe (and other) missing in windows install packages

Bug #31143	mysqlslap.exe (and other) missing in windows install packages
Submitted:	22 Sep 2007 10:12	Modified:	29 Jul 2010 14:36
Reporter:	Carsten Segieth	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Packaging	Severity:	S3 (Non-critical)
Version:	5.1.22	OS:	Windows (and Red Hat 4 (possibly more))
Assigned to:	Kent Boortz	CPU Architecture:	Any

Description:
mysqlslap.exe, myTest.exe, echo.exe and bug25714.exe is/are missing in both
 mysql-enterprise-5.1.22-rc-win32.zip
 mysql-enterprise-gpl-5.1.22-rc-win32.zip

but they are part of:
 mysql-enterprise-gpl-noinstall-5.1.22-rc-win32.zip
 mysql-enterprise-noinstall-5.1.22-rc-win32.zip

Same for the whole 'mysql-test' dir, it is missing in the installer.

Work around: unpack the 'noinstall' package if one of the missing items is needed.

How to repeat:
use installer and compare installed files with content of a 'noinstall' package

Suggested fix:
- installer called with 'complete' should install the same files as the 'noinstaller' package contains
- so either add missing stuff to the installer or remove it from the 'noinstall' packages, if it's "by decision" not needed.

Some RPMs do not have mysqlslap either, so there more are affected than just Windows installers.

For example, install the following and you'll see that mysqlslap does not exist:

MySQL-server-community-5.1.22-0.rhel4.x86_64.rpm
MySQL-client-community-5.1.22-0.rhel4.x86_64.rpm
MySQL-devel-community-5.1.22-0.rhel4.x86_64.rpm
MySQL-shared-community-5.1.22-0.rhel4.x86_64.rpm
MySQL-test-community-5.1.22-0.rhel4.x86_64.rpm

mysql-5.1.28-rc-winx64.zip is missing the files as well

seems to be in 5.1.29:

Directory of E:\mysql-5.1.29-rc-win32\bin
2008/10/13  18:10         2,052,096 mysqlslap.exe

mysql-5.1.32-win32.msi is missing the files as well

I verified this is also happening in latest 5.1.39 32 bit Windows installer. There was no mysqlslap.exe in $INSTALL_DIR/bin. The binary is however in the "No Installer" Windows package.

The RPMs have had mysqlslap since 5.1.30, keeping this bug open as the original issue (feature request) about Windows is still not solved.

In 5.5 there will be a new installer that contains everything that is in the "noinstall" package. The following patch will do the minimal change to 5.1 to include "mysqlslap.exe" and "libmysqld.def". The other executables are for use by the "mysql-test" regression tests, so of no use. Adding an executable named "echo.exe" that the user might put in the PATH could be dangerous anyway, might clash with another executable by that name.

--- source/wix/mysql_server_fragment_5.1.xml	(revision 187)
+++ source/wix/mysql_server_fragment_5.1.xml	(working copy)
@@ -81,6 +81,10 @@
                   <File Id="file489" Name="MYSQLTST.EXE" LongName="mysqltest.exe"  />
                   <File Id="file550" Name="MYSQL_CT.EXE" LongName="mysql_client_test.exe"  />
                   <File Id="file491" Name="replace.exe"  />
+                  <!-- <File Id="bin001"  Name="comp_err.exe"  /> -->
+                  <File Id="bin002"  Name="MYSQLSLA.EXE" LongName="mysqlslap.exe"  />
+                  <!-- <File Id="bin003"  Name="echo.exe"  /> -->
+                  <!-- <File Id="bin004"  Name="bug25714.exe"  /> -->
                   <?endif?>
                   <File Id="fild471" Name="mysql.pdb"  />
                   <File Id="file466" Name="libmySQL.dll"  />
@@ -226,6 +230,9 @@
                   <File Id="file810" Name="m_ctype.h"  />
                   <File Id="file811" Name="m_string.h"  />
                   <File Id="file813" Name="typelib.h"  />
+                  <?if ($(var.SETUP_TYPE) != "essential")?>
+                  <File Id="incl001" Name="LBMYSQLD.DEF" LongName="libmysqld.def" />
+                  <?endif?>
                 </Component>
                 <Directory Id="include_mysql" Name="mysql">
                     <Component Id="MySQLIncludeFiles" Guid="89D253A8-D429-430E-B1EA-399A17B4080D" DiskId="1">

Looks like it could work.

The "mysqlslap" executable will be included in MySQL Server 5.1.50, in both the 32-bit and 64-bit Windows MSI installers