Bug #30910 broken/invalid advisor expression causes endless notification

• Submitted: 7 Sep 2007 18:50
• Modified: 8 Aug 2008 16:02
• Reporter: Sloan Childers
• Status: Closed
• Category: MySQL Enterprise Monitor: Server
• Severity: S2 (Serious)
• Version: 2.0
• OS: Any
• Assigned to: Sloan Childers
• CPU Architecture: Any
• Tags: mer 121

[7 Sep 2007 18:50] Sloan Childers

Description:
this is a bug that only exists down an error path for a badly written advisor

an advisor with a SQL syntax error causes two SNMP traps (success,failure) to be sent with each evaluation of the advisor

bad behaviors noted
- endless log messages
- endless notifications
- encoding not UTF-8 for advisor import
- exceptions caught and rethrown just logged in data collection log again

How to repeat:
create a custom advisor with bad SQL syntax ie. string compare without the ticks on the literal
%dc_value% != value

Suggested fix:

- add back in code to disable the advisor after max failures
- log that we are disabling the advisor
- change stream to be UTF-8 for advisor import
- don't rethrow exceptions or duplicates are logged in data collection

[10 Sep 2007 0:11] Sloan Childers

r7548 development-1.2.1

[13 Nov 2007 17:37] Bill Weber

verified fixed in 1.2.0.7879

[16 Nov 2007 16:25] Peter Lavin

Added to the changelog for version 1.2.

[17 Nov 2007 18:46] Sloan Childers

Fixed in 1.2.1, reopening to fix in 2.0

[8 Aug 2008 16:02] Sloan Childers

I'm happy with log messages for bad advisor rules.  Never ending email notifications was the horrible problem this bug was originally opened to fix.