| Bug #2890 | Need to add darwin7 to configure.in for MySQL 4.0.x | ||
|---|---|---|---|
| Submitted: | 19 Feb 2004 5:48 | Modified: | 19 Feb 2004 6:14 |
| Reporter: | [ name withheld ] | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: Compiling | Severity: | S2 (Serious) |
| Version: | 4.0.x | OS: | MacOS (Mac OS X) |
| Assigned to: | Lenz Grimmer | CPU Architecture: | Any |
[19 Feb 2004 6:14]
Lenz Grimmer
Thanks a lot for the report! This has been resolved for upcoming releases
now:
ChangeSet@1.1737, 2004-02-19 00:00:20+01:00, lenz@mysql.com
- Make sure to set the correct compile flags for Mac OS X 10.3 "Panther"
(which is "darwin7" now) - "-DHAVE_BROKEN_REALPATH" is not required
anymore, too, as realpath() is thread-safe on Panther now.
(Thanks to Al Begley from Apple for the info)
Description: The source distribution of MySQL 4.0.x builds without the intended compile flags, on versions of Mac OS X starting with version 10.3 (Panther). The flags are applied by the configure script, in a switch statement that checks for the underlying OS version. For earlier versions of Mac OS X, the switch statement has cases for darwin5 (10.1) and darwin6 (10.2). A case needs to be added for darwin7 (10.3), and the associated compile flags need to be adjusted. How to repeat: Download the MySQL source onto a Mac OS X 10.3.x machine and run the configure script. Note that, for example, the "-DFN_NO_CASE_SENCE" flag is not passed. Suggested fix: Modify configure.in so that configure has the following: *** configure.orig Wed Feb 18 15:17:23 2004 --- configure Wed Feb 18 13:40:32 2004 *************** *** 23703,23708 **** --- 23703,23717 ---- MAX_C_OPTIMIZE="-O" fi ;; + *darwin7*) + if test "$ac_cv_c_compiler_gnu" = "yes" + then + FLAGS="-DHAVE_DARWIN_THREADS -D_P1003_1B_VISIBLE -DSIGNAL_WITH_VIO_CLOSE -DSIGNALS_DONT_BREAK_READ -DFN_NO_CASE_SENCE" + CFLAGS="$CFLAGS $FLAGS" + CXXFLAGS="$CXXFLAGS $FLAGS" + MAX_C_OPTIMIZE="-O" + fi + ;; *freebsd*) echo "Adding fix for interrupted reads" OSVERSION=`sysctl -a | grep osreldate | awk '{ print $2 }'` Note that the flags are the same as those for darwin6, except that "-DHAVE_BROKEN_REALPATH" has been removed because 10.3 has a thread-safe realpath().