MySQL Bugs: #27720: Failing tests without innodb and partition in 5.1-bktree

Bug #27720	Failing tests without innodb and partition in 5.1-bktree
Submitted:	9 Apr 2007 19:48	Modified:	29 Oct 2007 19:53
Reporter:	jocelyn fournier (Silver Quality Contributor)	Email Updates:
Status:	Can't repeat	Impact on me:	None
Category:	MySQL Server: Tests	Severity:	S3 (Non-critical)
Version:	5.1-bk	OS:	Any
Assigned to:	Matthias Leich	CPU Architecture:	Any
Tags:	Contribution, qc

Description:
Hi,

When running make test on a fresh 5.1 bktree compiled with ./BUILD/compile-pentium-debug (without partition or innodb support activated), I've noticed two failures because of missing partition and innodb features :

rpl_extraCol_myisam needs partition and rpl_row_basic_11bugs needs innodb, but doesn't contain the proper includes.

Regards,
  Jocelyn

How to repeat:
run make test after ./BUILD/compile-pentium-debug on the latest 5.1 bktree.

Suggested fix:
--- /home/jocelyn/mysql-5.1-ref/mysql-test/t/rpl_extraCol_myisam.test  2007-04-02 10:37:21.000000000 +0200
+++ ./rpl_extraCol_myisam.test  2007-04-09 16:45:48.000000000 +0200
@@ -4,6 +4,7 @@
 # Purpose: Wapper for rpl_extraSlave_Col.test
 #          Using MyISAM
 ###########################################
+-- source include/have_partition.inc
 -- source include/have_binlog_format_row.inc
 -- source include/master-slave.inc
 let $engine_type = 'MyISAM';
diff -u /home/jocelyn/mysql-5.1-ref/mysql-test/t/rpl_row_basic_11bugs.test ./rpl_row_basic_11bugs.test
--- /home/jocelyn/mysql-5.1-ref/mysql-test/t/rpl_row_basic_11bugs.test  2007-03-29 21:37:59.000000000 +0200
+++ ./rpl_row_basic_11bugs.test 2007-04-09 20:48:04.000000000 +0200
@@ -1,5 +1,5 @@
 --source include/have_binlog_format_row.inc
-
+-- source include/have_innodb.inc

 let $SERVER_VERSION=`select version()`;

Verified for rpl_row_basic_11bugs (it does require innodb, but has no appropriate source command) with latest 5.1.20-BK on Linux.

As for rpl_extraCol_myisam test, currently it looks like:

###########################################
# Author: Jeb
# Date: 2006-09-07
# Purpose: Wapper for rpl_extraSlave_Col.test
#          Using MyISAM
###########################################
-- source include/have_binlog_format_row.inc
-- source include/master-slave.inc
let $engine_type = 'MyISAM';
-- source extra/rpl_tests/rpl_extraSlave_Col.test

And, in turn, extra/rpl_tests/rpl_extraSlave_Col.test:

#################################################
# Author: Jeb
# Date:   2006-09-07
# Purpose: To test having extra columns on the slave.
##################################################

# Some tests in here requre partitioning
-- source include/have_partition.inc
...

starts with

-- source include/have_partition.inc

so I do not see any problem with this test.

Thank you for your bug report.

I checked today the tests mentioned above on
   mysql-5.1-build ChangeSet@1.2591, 2007-10-29
   ./BUILD/compile-pentium-debug
and was unable to repeat the problem.

ChangeSet@1.2469.1.114, 2007-04-25
"Fix test case that was broken for builds without InnoDB"
fixed several problems including this bug.
Note: There might be a delay of some weeks between commit
      of changeset and availability of bug fix within the
      official MySQL source trees.

Result:
   rpl.rpl_extraCol_myisam [ skipped ] 
             Test requires: 'have_partition'
The fix was:
   add a line "-- source include/have_partition.inc"
   to extra/rpl_tests/rpl_extraSlave_Col.test

Result:
   rpl.rpl_row_basic_11bugs [ pass ]
The fix was:
   add "--disable_warnings" and "--enable-warnings"
   to suite/rpl/t/rpl_row_basic_11bugs.test
   In case of missing InnoDB the default storage
   engine MyISAM is used instead.
   "--disable_warnings" suppresses the corresponding
   warning of the server.

Regards,
  Matthias Leich