Bug #25612 Please make some atrributes of Item_* classes public (patch provided)
Submitted: 13 Jan 2007 21:37 Modified: 1 Oct 2008 22:58
Reporter: Philip Stoev Email Updates:
Status: Won't fix Impact on me:
None 
Category:MySQL Server: General Severity:S3 (Non-critical)
Version:5.0.33 OS:Any
Assigned to: Chad MILLER CPU Architecture:Any
Tags: Contribution

[13 Jan 2007 21:37] Philip Stoev 
Description:
Hello,

Please apply the following patch to the 5.0 tree. It makes some private attributes of a few Item_* classes public, so that their contents can be explored when walking through the parse tree.

I had to rearrange some constructors in order to silence some compilation warnings. The patched source appears to compile cleanly and passes the test sute.

Thank you very much in advance. This change will help the DBIx::MyParse project.

How to repeat:
Attempt to walk the parse tree -- you will see that right now some Item_ objects do not expose enough of their properties to allow the reconstruction of the original SQL query.

Suggested fix:
Patch will be attached to the bug report.
[13 Jan 2007 21:38] Philip Stoev 
Make some Item_* class properties public

Attachment: myparse.patch (text/plain), 5.77 KiB.
[13 Jan 2007 23:42] MySQL Verification Team 
Thank you for the bug report and contribution.
[18 Jan 2007 22:44] Konstantin Osipov 
Philip, 
could you please provide a more elaborate explanation why this needs to be done?
Is it possible to use Item::walk* family of methods instead?
[20 Jan 2007 13:57] Philip Stoev 
Please see:

http://lists.mysql.com/internals/34253

for further justification regarding the patch.
[1 Oct 2008 22:58] Konstantin Osipov 
We're solving the problem in part with abstract query trees.
Making more things public, even optionally, is not something we should do.
Thanks you.