Bug #25240 Build tools modify tool files after tree setup

• Submitted: 22 Dec 2006 10:21
• Modified: 28 Aug 2007 12:59
• Reporter: Joerg Bruehe
• Status: Closed
• Category: MySQL Server: Compiling
• Severity: S3 (Non-critical)
• Version: All
• OS: Any (All)
• Assigned to: Joerg Bruehe
• CPU Architecture: Any

[22 Dec 2006 10:21] Joerg Bruehe

Description:
Detected when dealing with "Do-build-specific-RPMs.pl",
but might be present elsewhere also:

When running, the tool will do a 
  system("cp -p $ENV{HOME}/my/internals/build/NetworkRPMS/* $buildDir/specs/.");

As we now initialize the build tree with its tools when creating the screen session, it is wrong to copy any such files later, because we may have local modifications already (test builds, last-minute-fixes, ...).

How to repeat:
Code analysis.

Alternative: Run a test build, 
in which you rename the "internals" tree after tree setup, 
but before starting the actual build.

Suggested fix:
Check all tools for similar actions.

Verify the initial setup provides those files.

Remove all such copy actions from the tools, the initial setup is sufficient.

[28 Aug 2007 12:59] Joerg Bruehe

The specific issue has already been fixed in March,
and a code analysis of all tools has not delivered any other questionable action.

So I close this,
we can still do the test build with renamed "internals" tree as proposed at a suitable time.