Bug #24777 | gui-common build fails with Lua 5.1.1 | ||
---|---|---|---|
Submitted: | 2 Dec 2006 15:44 | Modified: | 13 Dec 2006 0:10 |
Reporter: | [ name withheld ] | Email Updates: | |
Status: | Won't fix | Impact on me: | |
Category: | MySQL Workbench Preview | Severity: | S1 (Critical) |
Version: | 5.0r6 | OS: | Linux (linux ubuntu edgy eft) |
Assigned to: | CPU Architecture: | Any |
[2 Dec 2006 15:44]
[ name withheld ]
[13 Dec 2006 0:10]
MySQL Verification Team
Thank you for the bug report.
[16 Jan 2007 0:30]
Narcelio Filho
Here is a small patch to compile MySQL gui-common with Lua 5.1.1. But MySQL Workbench still doesn't runs well, it always crashes with crypt errors messages like: "PANIC: unprotected error in call to Lua API (no calling environment)" Maybe those guidelines must be followed to make full migration: http://lua-users.org/wiki/MigratingToFiveOne Index: library/generic-runtime/source/myx_grt_lua.c =================================================================== --- library/generic-runtime/source/myx_grt_lua.c (revision 1924) +++ library/generic-runtime/source/myx_grt_lua.c (working copy) @@ -39,7 +39,7 @@ { "string", luaopen_string }, { "math", luaopen_math }, { "debug", luaopen_debug }, - { "loadlib", luaopen_loadlib }, + { "package", luaopen_package }, { "lxp", luaopen_lxp }, { NULL, NULL } }; Index: library/generic-runtime/source/lxp/lxplib.c =================================================================== --- library/generic-runtime/source/lxp/lxplib.c (revision 1924) +++ library/generic-runtime/source/lxp/lxplib.c (working copy) @@ -334,9 +334,7 @@ lua_pushnil(L); while (lua_next(L, 1)) { lua_pop(L, 1); /* remove value */ - if (lua_type(L, -1) != LUA_TSTRING || - luaL_findstring(lua_tostring(L, -1), validkeys) < 0) - luaL_error(L, "invalid key `%s' in callback table", lua_tostring(L, -1)); + luaL_checkoption(L, -1, NULL, validkeys); } }