Bug #22951 Sysfile file format comment incorrect
Submitted: 3 Oct 2006 16:57 Modified: 3 Jan 2007 3:36
Reporter: Stewart Smith Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Cluster: Cluster (NDB) storage engine Severity:S3 (Non-critical)
Version:5.1 OS:
Assigned to: Stewart Smith CPU Architecture:Any

[3 Oct 2006 16:57] Stewart Smith 
Description:
in sysfile.hpp, comment is incorrect on 5.1 file format

How to repeat:
read source, notice comment is wrong

Suggested fix:
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2005/11/29 08:08:02+01:00 stewart@mysql.com
#   Sysfile.hpp:
#     correct comment for 5.1 sysfile file format
#
# storage/ndb/src/kernel/blocks/dbdih/Sysfile.hpp
#   2005/11/29 08:07:11+01:00 stewart@mysql.com +2 -2
#   correct comment for >= 1 sysfile file format
#
diff -Nru a/storage/ndb/src/kernel/blocks/dbdih/Sysfile.hpp b/storage/ndb/src/kernel/blocks/dbdih/Sysfile.hpp
--- a/storage/ndb/src/kernel/blocks/dbdih/Sysfile.hpp   2006-10-04 02:55:23 +10:00
+++ b/storage/ndb/src/kernel/blocks/dbdih/Sysfile.hpp   2006-10-04 02:55:23 +10:00
@@ -34,8 +34,8 @@

 /**
  * No of 32 bits word in sysfile
- *
- *   5 +
+ *
+ *   6 +                                           // was 5 in < version 5.1
  *   MAX_NDB_NODES +                               // lastCompletedGCI
  *   NODE_ARRAY_SIZE(MAX_NDB_NODES, 4) +           // nodeStatus
  *   NODE_ARRAY_SIZE(MAX_NDB_NODES, NODEID_BITS) + // nodeGroups
[4 Oct 2006 7:45] Stewart Smith 
pushed to 5.1-ndb
[29 Dec 2006 0:41] Stewart Smith 
in 5.1.14, probably no need to document, unless this is covered in any internals docs.
[3 Jan 2007 3:36] Jon Stephens 
I agree with Stewart's previous note - this is of little if any interest to end users; closing without further action at this time.