MySQL Bugs: #21506: Server unInstall removes user created objects without warning (br 1715)

Bug #21506	Server unInstall removes user created objects without warning (br 1715)
Submitted:	8 Aug 2006 13:50	Modified:	3 Apr 2007 21:14
Reporter:	Carsten Segieth	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Enterprise Monitor: Installing	Severity:	S3 (Non-critical)
Version:	0.5.19 - 0.7.34	OS:
Assigned to:	BitRock Merlin	CPU Architecture:	Any
Tags:	default button, uninstall

Description:
The Merlin Server unInstall removes ALL files and directories below the installation directory without any notice about this.

So it will happen that in case of a planned update installation also the /mysql/data directory is removed. Also all other files that were created after the installation are removed.

How to repeat:
- install 0.5.19
- create a file inside the installation directory
- uninstall

Suggested fix:
- leave all user created objects
- or at least ask the user and inform him that then also the mysql/data dir and the log dirs of Apache and Apache Tomcat are removed.

test failed with 0.5.23 on Windows:

The new question asks whether also the user created objects shall be removed. I answered 'NEIN' (= no), but all logs and database files were removed.

- in progress (I could not change the status field of this bug)

- problem still exists with 0.5.24, tested on Win2003 and XP, with the strange behaviour, that e.g. the apache*/logs dirs were removed, but the mysql/data directory reains when 'NO' is answered on Win2003. 

end of a recent unInstall.log:
Uninstalling C:\Documents and Settings\All Users\Start Menu\Programs\MySQL Network...
Invalid action ruleList
Uninstallation completed

- request to fix it sent to BitRock
- BitRock support case 1319

seen with 0.6.19 on Suse 9.3:

Even the question only asks to remove 'data' and 'logs' all files and directories below the installation dir, except files in the installdir itself, are removed.

Either the question needs to warn that 'everything' (and not only data and logs) below the installdir is removed or the unInstall should only remove what the installer created. 

Or, browse the tree and show a list of all files / dirs that shall be removed for confirmation.

Bitrock builds > 6.19 should have this corrected.

still present with 0.6.33 - see also my comment from Sept 21 above.

How to reproduce:
-----------------

Have user created files (I had a copy of the my.ini file) in the tree and watch that they are removed - although I only said 'yes' to remove 'log and data files' whan I was asked.

It seems that ALL files are removed when this question is answered with YES.

Using uninstall 0.7.4 the directory, where I installed to, was removed, including all files / directories in that where already present BEFORE! the installation. I've answered the '? remove log+data' question with YES.

It looks for me that not the installed files are logged to be removed at uninstall, but the whole directory tree is cleaned from a script?

Reported as corrected by Bitrock in build versions >= 7.5

tested with 0.7.18 on Windows: I answered the 'Remove log+data' question with YES and all files including the installation directory were removed, including all files that were not created by the installer (regardless whether they were presente befor installing or created after installing).

I see that my testing environment with some test data inside the dir where I install to is not a case which will happen so often, so I would accept the behaviour to remove *all data* including/below the installation dir.

But then the text of the question needs to be changed to something like show below (please correct my 'not perfect' English, if needed):

------------------------------
Do you like to remove all data, logs and other files below '<INSTALLATIONDIR>'?

Caution, this will remove all user created files, even if they were present before installing MySQL Network Monitoring and Advisory Service, including the data files of the bundled MySQL server. You will *not* be able to undo this action. Do not use this option in case of a planned update install!

Do you really want to remove ALL data and log files inside '<INSTALLDIR>'?

(YES - NO)
------------------------------
... with a default on 'NO' !

0.7.27 - still all files are removed when answering the "remove 'data + log' ?" question with YES.

This issue has been fixed in the server and agent installer builds we provided on 11/09.

We look forward to your feedback.

Best regards,

Ivan
BitRock Support

Reported as resolved by Bitrock in ver => 7.29

with 0.7.30 the new question is implemented, but:

- the default (focus) is on the 'Yes' button, it should be on the 'No' button to prevent users from accidently choose 'Yes' just by clicking on ENTER.
- there is a wording mistake. The first sentence is 
  "Do you also to remove ..." and it should be "Do you also want to remove ..."

new question

Attachment: bug#uninstall_question_with_wording_problems.jpg (image/jpeg, text), 21.15 KiB.

the unInstall removed all directories below, but left the installation dir itself with some user created files in. After checking the wording of the question this is the action described in the message box --> OK.

Reported as resolved by Bitrock in ver => 7.32

downgraded to P3 for the remaining change of the default button where the focus is on and also changed to 'To be fixed later'.

now marked as 'solved', as only the remaining change of the default button is open (see new created bug#27609 - server unInstall - default button of "remove all data" question should be 'NO').

Added to the changelog.