Bug #19394 Duplicate my_long_options[].id OPT_INNODB_THREAD_CONCURRENCY in mysqld.cc
Submitted: 27 Apr 2006 7:50 Modified: 9 Jun 2006 13:35
Reporter: Marko Mäkelä Email Updates:
Status: Closed Impact on me:
Category:MySQL Server Severity:S2 (Serious)
Version:5.0, 5.1 OS:Any (all)
Assigned to: Elliot Murphy CPU Architecture:Any

[27 Apr 2006 7:50] Marko Mäkelä
While analyzing Bug #19071, I noticed in mysqld.cc that the constant OPT_INNODB_THREAD_CONCURRENCY is used also for "innodb_commit_concurrency". I wonder if this has any visible effect to the user, but I suggest that a new constant (OPT_INNODB_COMMIT_CONCURRENCY) be introduced for the sake of consistency.

How to repeat:
Search for OPT_INNODB_THREAD_CONCURRENCY in the source file sql/mysqld.cc

Suggested fix:
Ensure that there are no duplicate id values in the definition of my_long_options[].
[27 Apr 2006 13:49] Valeriy Kravchuk
Thank you for a problem report. Verified just as described with today's BK sources, 5.0-BK (ChangeSet@1.2096.1.3, 2006-04-26 20:50:27-07:00) and 5.1-BK (ChangeSet@1.2368, 2006-04-27 08:25:55+02:00):

openxs@suse:~/dbs/5.0> grep -n OPT_INNODB_THREAD_CONCURRENCY ~/work/mysql-5.0/sql/mysqld.cc
5518:  {"innodb_commit_concurrency", OPT_INNODB_THREAD_CONCURRENCY,
5567:  {"innodb_thread_concurrency", OPT_INNODB_THREAD_CONCURRENCY,
openxs@suse:~/dbs/5.0> grep -n OPT_INNODB_THREAD_CONCURRENCY ~/work/mysql-5.1-new/sql/mysqld.cc
5774:  {"innodb_commit_concurrency", OPT_INNODB_THREAD_CONCURRENCY,
5823:  {"innodb_thread_concurrency", OPT_INNODB_THREAD_CONCURRENCY,
[6 Jun 2006 11:21] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

[9 Jun 2006 13:22] Elliot Murphy
Patch has now been merged from team tree to 5.0 and 5.1
Fix is in 5.1.12
Fix is in 5.0.23
I don't think this is a user-visible change.
[9 Jun 2006 13:35] Paul DuBois
No changelog entry needed.