MySQL Bugs: #19296: autopush ignores the --no

Bug #19296	autopush ignores the --no_push option
Submitted:	24 Apr 2006 11:30	Modified:	10 Jan 2007 19:04
Reporter:	Matthias Leich	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Compiling	Severity:	S2 (Serious)
Version:	4.1	OS:
Assigned to:	Jani Tolonen	CPU Architecture:	Any

Description:
This bug does not affect MySQL software releases or customers.
But it may harm the software development with not intended pushes.

I wanted to check my changes of testscripts by using of
the autopush tool. But I did not intend to push my changes to the
source tree. That's the reason why I used the "--no_push" option.

Sniplet of my screen history:
----------------------------------
...
mleich@three:~/Arbeit/mysql-4.1/src> export MTR_BUILD_THREAD=17
mleich@three:~/Arbeit/mysql-4.1/src> ~/Arbeit/internals/dev/autopush --no_push --use_bkd
autopush: Checking for needed tools and access to machines..
autopush: Preparing source tree at build host
autopush.16775: Doing bk pull from launch dir to build dir
autopush.16775: Pulling latest from target source tree (target host)
autopush.16775: Building. Using compile-pentium-debug-max
autopush.16775: Running tests
autopush.16775: Pushing to main tree <-- This should not happen.
autopush.16775: Done.
...
Unfortunately I detected this suspicious line some days later.

Sniplet of autopush.16775.log (stored on build host)
----------------------------------------------------------------
...
Consistency check passed, resolve complete.
Push queued for pushbuild at https://intranet.mysql.com/~knielsen/pb/mysql-4.1/.
autopush.16775: Finished at Thu Apr 20 14:35:34 CEST 2006

Sniplet of bk changes:
---------------------------
...
ChangeSet@1.2453.36.2, 2006-04-13 20:42:48+02:00, mleich@mysql.com
Fixes for Bug#12429: Replication tests fail: "Slave_IO_Running" (?) differs related to
MySQL 4.1
...

Please tell me if you need more informations.
I saved some of the autopush scripts and protocols.

How to repeat:
N/A

In  my opinion, the problem is that not all (required) options are transferred to the remote instance of the autopush script (./$PROGNAME.$PID). So there may be more options that have no effect.

This concerns old autopush shell version.

Tested with current 4.10 autopush.pl (Perl) version
and the bug doesn't exists there.