Bug #19189 mysql-5.0.20/install-sh from source tarball fails in some cases
Submitted: 19 Apr 2006 10:33 Modified: 19 Apr 2006 12:49
Reporter: Friedrich Haubensak Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server Severity:S2 (Serious)
Version:5.0.20 OS:Any (any)
Assigned to: CPU Architecture:Any

[19 Apr 2006 10:33] Friedrich Haubensak
Description:
the sed-command in line 210 of mysql-5.0.20/install-sh is claimed to emulate the dirname command, but it misses the case of an / at the end of it's argument,  and so "make install" does not work if @PACKAGE@ (from config.status) is empty

[ if you ask: why should this happen ? -- to get a directory structure ..../mysql/{bin,include,lib,.... ]

How to repeat:

./configure ....

set @PACKAGE@ to empty value in config.status
./config.status
make
make install

Suggested fix:
--- install-sh  Fri Mar 31 19:11:33 2006
+++ install-sh.new      Tue Apr 18 17:00:48 2006
@@ -206,9 +206,9 @@
     fi
   fi
 
   # This sed command emulates the dirname command.
-  dstdir=`echo "$dst" | sed -e 's,[^/]*$,,;s,/$,,;s,^$,.,'`
+  dstdir=`echo "$dst" | sed -e 's,/$,,;s,[^/]*$,,;s,/$,,;s,^$,.,'`
 
   # Make sure that the destination directory exists.
 
   # Skip lots of stat calls in the usual case.
[19 Apr 2006 10:41] Valeriy Kravchuk
Thank you for a problem report. In 5.0.21-BK we have:

# This sed command emulates the dirname command.
dstdir=`echo "$dst" | sed -e 's,/*$,,;s,[^/]*$,,;s,/*$,,;s,^$,.,'`

Please, check if it will work in your case.
[19 Apr 2006 12:49] Friedrich Haubensak
sure, this works.
even more bullet-proof than my proposal :-)