Bug #14668 | funktions storing in machine independent format not optimized for PPC | ||
---|---|---|---|
Submitted: | 5 Nov 2005 8:19 | Modified: | 20 May 2009 7:20 |
Reporter: | Gunnar von Boehn | Email Updates: | |
Status: | Verified | Impact on me: | |
Category: | MySQL Server | Severity: | S5 (Performance) |
Version: | 5.0.16-BK, 5.1.34 | OS: | Any (any) |
Assigned to: | CPU Architecture: | Any |
[5 Nov 2005 8:19]
Gunnar von Boehn
[6 Nov 2005 8:31]
Valeriy Kravchuk
Verified also on 5.0.16-BK sources (ChangeSet@1.1957.1.18, 2005-11-03 20:29:21+02:00, jani@ua141d10.elisa.omakaista.fi). Line 1183 of includes/my_global.h (not in #ifdef block): #define int4net(A) (int32) (((uint32) ((uchar) (A)[3])) |\ (((uint32) ((uchar) (A)[2])) << 8) |\ (((uint32) ((uchar) (A)[1])) << 16) |\ (((uint32) ((uchar) (A)[0])) << 24))
[12 Oct 2007 18:40]
Konstantin Osipov
Thank you for a valid performance request.
[20 May 2009 7:20]
Valeriy Kravchuk
In 5.1.34 my_global.h still has this same definition (not in #ifdef): /* Macro for reading 32-bit integer from network byte order (big-endian) from unaligned memory location. */ #define int4net(A) (int32) (((uint32) ((uchar) (A)[3])) |\ (((uint32) ((uchar) (A)[2])) << 8) |\ (((uint32) ((uchar) (A)[1])) << 16) |\ (((uint32) ((uchar) (A)[0])) << 24))
[20 May 2009 7:20]
Valeriy Kravchuk
In 5.1.34 my_global.h still has this same definition (not in #ifdef): /* Macro for reading 32-bit integer from network byte order (big-endian) from unaligned memory location. */ #define int4net(A) (int32) (((uint32) ((uchar) (A)[3])) |\ (((uint32) ((uchar) (A)[2])) << 8) |\ (((uint32) ((uchar) (A)[1])) << 16) |\ (((uint32) ((uchar) (A)[0])) << 24))
[27 May 2014 3:10]
Stewart Smith
Just a FYI: I haven't yet seen this show up on a profile. So I'm not sure this is actually much of an issue.