Description:
Two MTR include files set an MTR variable SERVER_NAME which is never used.
suite/funcs_1/datadict/datadict_load.inc:
# prepare a variable to be able to suppress machine dependant diffs
# this can be used in: --replace_result $SERVER_NAME <SERVER_NAME>
# let $SERVER_NAME= `SELECT DISTINCT host FROM mysql.user WHERE host LIKE "%\%" AND host NOT In ("localhost", "127.0.0.1", "%")`;
let $SERVER_NAME= `SELECT DISTINCT host FROM mysql.user WHERE host NOT In ("localhost", "127.0.0.1", "%")`;
suite/funcs_1/datadict/datadict.pre:
# Prepare a variable to be able to suppress machine dependant diffs
# this can be used in: --replace_result $SERVER_NAME <SERVER_NAME>
let $SERVER_NAME= `SELECT DISTINCT host FROM mysql.user
WHERE host NOT In ("localhost", "127.0.0.1", "%")`;
But nothing nowhere uses them
How to repeat:
Read, grep
Suggested fix:
Remove
Description: Two MTR include files set an MTR variable SERVER_NAME which is never used. suite/funcs_1/datadict/datadict_load.inc: # prepare a variable to be able to suppress machine dependant diffs # this can be used in: --replace_result $SERVER_NAME <SERVER_NAME> # let $SERVER_NAME= `SELECT DISTINCT host FROM mysql.user WHERE host LIKE "%\%" AND host NOT In ("localhost", "127.0.0.1", "%")`; let $SERVER_NAME= `SELECT DISTINCT host FROM mysql.user WHERE host NOT In ("localhost", "127.0.0.1", "%")`; suite/funcs_1/datadict/datadict.pre: # Prepare a variable to be able to suppress machine dependant diffs # this can be used in: --replace_result $SERVER_NAME <SERVER_NAME> let $SERVER_NAME= `SELECT DISTINCT host FROM mysql.user WHERE host NOT In ("localhost", "127.0.0.1", "%")`; But nothing nowhere uses them How to repeat: Read, grep Suggested fix: Remove