Bug #117347 Contribution: Fix typing annotation of MySQLConnectionAbstract\'s `close` f ...
Submitted: 30 Jan 19:17 Modified: 11 Mar 0:32
Reporter: OCA Admin (OCA) Email Updates:
Status: Closed Impact on me:
None 
Category:Connector / Python Severity:S3 (Non-critical)
Version:9.2 OS:Any
Assigned to: CPU Architecture:Any
Tags: Contribution

[30 Jan 19:17] OCA Admin 
Description:
This bug tracks a contribution by Parul Gupta (Github user: parulgupta1004), as described in http://github.com/mysql/mysql-connector-python/pull/99

How to repeat:
See description

Suggested fix:
See contribution code attached
[30 Jan 19:17] OCA Admin 
Contribution submitted via Github - Fix typing annotation of MySQLConnectionAbstract's `close` function 
(*) Contribution by Parul Gupta (Github parulgupta1004, mysql-connector-python/pull/99#issuecomment-2624978362): I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: git_patch_2280147751.txt (text/plain), 1.83 KiB.
[31 Jan 4:47] MySQL Verification Team 
Hello Parul Gupta,

Thank you for the report and contribution.

regards,
Umesh
[10 Mar 14:26] Oscar Pacheco 
Posted by developer:
 
As part of the connection API, improved the type
hint of `close()` which is an alias of the instance
method `disconnect()`. Thanks, Parul Gupta, for the
contribution!
[11 Mar 0:32] Daniel So 
Posted by developer:
 
Added the following entry to the Connector/Python 9.3.0 changelog: 

"Fixed the typing annotation of the close() function of MySQLConnectionAbstract and also made disconnect() an alias of close(), to improve clarity and consistency of the connection API."