Description:
The funcs_1 suite contains additional tests for views, i_s, and sp, while funcs_2 covers combinations of charsets and collations.
I suppose views etc are more likely to be involved in changes than charsets, it is reasonable to run funcs_1 per push (default.push), while funcs_2 daily (default.daily). Such statement could be verified in default.daily: ... not part of the default - funcs_2, ...
However, WL#12261 obviously mistyped funcs_1 to be funcs_2, because it has little to do with funcs_2, leaving funcs_1 untested for months. Although Bug#29434134 added it back in default.daily and default.weekly, funcs_1 is still not in DEFAULT_SUITES and explicitly per push, thus probably untested by dev teams.
commit ca0f8cc03f9da58a895809af4f9a0653c07e9837
Author: Srikanth B R <srikanth.b.r@oracle.com>
Date: Mon Apr 1 16:46:40 2019 +0530
Bug#29434134 RUN FUNCS_1 IN DAILY AND WEEKLY SUITES // added funcs_1 back
commit 1d9fb1a8c9ba4bd9bdbc0d893fea0b3c1f5b605a
Author: Gopal Shankar <gopal.shankar@oracle.com>
Date: Mon Dec 10 05:04:14 2018 +0100
WL#12261 Control (enforce and disable) table encryption // obviously mistyped funcs_1 as funcs_2
commit de6424afba8a18c7523ab43d64e02b0fe027c7ca
Author: Vinay Fisrekar <vinay.fisrekar@sun.com>
Date: Wed Mar 23 17:07:04 2011 +0530
BUG#11867052 - ADD FUNCS_1 TO THE DEFAULT SUITE LIST IN MYSQL-TEST-RUN.PL // added funcs_1
How to repeat:
Run ./mtr without explicit suites and observe the output:
Using suite(s): auth_sec,binlog,binlog_gtid,binlog_nogtid,clone,collations,component_keyring_file,connection_control,encryption,federated,funcs_2,gcol,gis,information_schema,innodb,innodb_fts,innodb_gis,innodb_undo,innodb_zip,interactive_utilities,json,main,opt_trace,parts,perfschema,query_rewrite_plugins,rpl,rpl_gtid,rpl_nogtid,secondary_engine,service_status_var_registration,service_sys_var_registration,service_udf_registration,sys_vars,sysschema,test_service_sql_api,test_services,x
Suggested fix:
Please add funcs_1 back to DEFAULT_SUITES, and move func_2 out, making it conforming to the comments.
Bug#29434134 could be reverted.
diff --git a/mysql-test/collections/default.daily b/mysql-test/collections/default.daily
index 633f4a2308ef..20c47b524316 100644
--- a/mysql-test/collections/default.daily
+++ b/mysql-test/collections/default.daily
@@ -48,7 +48,6 @@ perl mysql-test-run.pl --force --timer --parallel=8 --comment=ps --vardir=var-p
# Run the suites that are not part of the default - funcs_2, stress, jp, nist
# engines, memcached, audit_null
perl mysql-test-run.pl --force --timer --big-test --testcase-timeout=60 --comment=audit_null-big --vardir=var-audit_null-big --suite=audit_null --no-skip
-perl mysql-test-run.pl --force --timer --big-test --testcase-timeout=60 --comment=funcs1-big --vardir=var-funcs1-big --suite=funcs_1 --no-skip
perl mysql-test-run.pl --force --timer --big-test --testcase-timeout=60 --comment=funcs2-big --vardir=var-funcs2-big --suite=funcs_2 --no-skip
perl mysql-test-run.pl --force --timer --big-test --comment=stress --vardir=var-stress --suite=stress --no-skip
perl mysql-test-run.pl --force --timer --big-test --comment=jp --vardir=var-jp --suite=jp --no-skip
diff --git a/mysql-test/collections/default.weekly b/mysql-test/collections/default.weekly
index 7685d3ca27c1..c81c19923915 100644
--- a/mysql-test/collections/default.weekly
+++ b/mysql-test/collections/default.weekly
@@ -46,7 +46,6 @@ perl mysql-test-run.pl --debug-server --force --timer --big-test --testcase-time
# Run the suites that are not part of the default - funcs_2, stress, jp, nist
# engines, memcached
perl mysql-test-run.pl --debug-server --force --timer --big-test --testcase-timeout=60 --comment=audit_null-big --vardir=var-audit_null-big --suite=audit_null --no-skip
-perl mysql-test-run.pl --debug-server --force --timer --big-test --testcase-timeout=60 --comment=funcs1-big --vardir=var-funcs1-big --suite=funcs_1 --no-skip
perl mysql-test-run.pl --debug-server --force --timer --big-test --testcase-timeout=60 --comment=funcs2-big --vardir=var-funcs2-big --suite=funcs_2 --no-skip
perl mysql-test-run.pl --debug-server --force --timer --big-test --comment=stress --vardir=var-stress --suite=stress --no-skip
perl mysql-test-run.pl --debug-server --force --timer --big-test --comment=jp --vardir=var-jp --suite=jp --no-skip
diff --git a/mysql-test/mysql-test-run.pl b/mysql-test/mysql-test-run.pl
index 74d610e15e18..55f1fb21ac2f 100755
--- a/mysql-test/mysql-test-run.pl
+++ b/mysql-test/mysql-test-run.pl
@@ -239,7 +239,7 @@ our @DEFAULT_SUITES = qw(
connection_control
encryption
federated
- funcs_2
+ funcs_1
gcol
gis
information_schema
