Bug #112456 Unused/write-only mtr_t::m_sync, set_sync, is_async, mtr_t::Command::m_sync

• Submitted: 25 Sep 2023 8:20
• Modified: 25 Sep 2023 8:48
• Reporter: Laurynas Biveinis (OCA)
• Status: Verified
• Category: MySQL Server: InnoDB storage engine
• Severity: S3 (Non-critical)
• Version: 8.1.0, probably others
• OS: Any
• CPU Architecture: Any

[25 Sep 2023 8:20] Laurynas Biveinis

Description:
The field mtr_t::Command::m_sync is written to in init method and then never read.

How to repeat:
Read mtr0mtr.cc

Suggested fix:
Remove the field

[25 Sep 2023 8:24] Laurynas Biveinis

Oh, the enclosing mtr_t::m_sync is not used neither. Will update title and description.

[25 Sep 2023 8:26] Laurynas Biveinis

The field mtr_t::Command::m_sync is write-only.
The field mtr_t::m_sync is write-only (it is used only for Command::m_sync above initialization). This includes the setter for the field: set_sync method.
The method mtr_t::is_async() is never called.

[25 Sep 2023 8:48] MySQL Verification Team

Hello Laurynas,

Thank you for the report and feedback!

regards,
Umesh