Bug #111606 Contribution: Fix hard-coded timestamps in main.derived_condition_pushdown ...

• Submitted: 28 Jun 2023 14:26
• Modified: 3 Jul 2023 8:03
• Reporter: OCA Admin (OCA)
• Status: Closed
• Category: MySQL Server: General
• Severity: S3 (Non-critical)
• OS: Any
• CPU Architecture: Any

[28 Jun 2023 14:26] OCA Admin

Description:
This bug tracks a contribution by Daniel Lenski (Github user: dlenski) as described in http://github.com/mysql/mysql-server/pull/469

How to repeat:
See description

Suggested fix:
See contribution code attached

[28 Jun 2023 14:26] OCA Admin

Contribution submitted via Github - Fix hard-coded timestamps in main.derived_condition_pushdown MTR test 
(*) Contribution by Daniel Lenski (Github dlenski, mysql-server/pull/469#issuecomment-1595091742): This contribution is under the OCA signed by Amazon and covering submissions to the MySQL project.

Contribution: git_patch_1363440758.txt (text/plain), 3.34 KiB.

[3 Jul 2023 8:03] Erlend Dahl

Thank you for the contribution. The problem was noticed internally and has been fixed in the upcoming 8.0.34 release by the following patch:

diff --git a/mysql-test/t/derived_condition_pushdown.test b/mysql-test/t/derived_condition_pushdown.test
index cfa748f5ec0..0d7dd41f698 100644
--- a/mysql-test/t/derived_condition_pushdown.test
+++ b/mysql-test/t/derived_condition_pushdown.test
@@ -1313,9 +1313,11 @@ eval PREPARE stmt FROM "EXPLAIN FORMAT=tree $query";
 eval EXECUTE stmt USING @a, @b;
 SET @a = 2;
 SET @b = '2023-05-06 16:49:45';
+SET timestamp=UNIX_TIMESTAMP('2023-05-06 16:49:45');
 --replace_regex $elide_costs
 --skip_if_hypergraph  # Depends on the query plan.
 eval EXECUTE stmt USING @a, @b;
+SET timestamp=default;
 
 DROP TABLE t1;

[3 Jul 2023 16:30] Daniel Lenski

> The problem was noticed internally and has been fixed in the upcoming 8.0.34 release by the following patch:

Erlend Dahl, the patch you show won't even fix the problem.

Did you actually test my PR?