Bug #111518 optimize for Zstd_comp::close

• Submitted: 21 Jun 2023 13:13
• Modified: 22 Jun 2023 12:37
• Reporter: alex xing (OCA)
• Status: Closed
• Category: MySQL Server: Connection Handling
• Severity: S5 (Performance)
• Version: 8.0
• OS: Any
• CPU Architecture: Any

[21 Jun 2023 13:13] alex xing

Description:
It is not necessary to maintain m_buffer_cursor twice in Zstd_comp::close

How to repeat:
just read the code

Suggested fix:
Just maintain it once

[21 Jun 2023 13:14] alex xing

a simple patch to describe the optimization

(*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: optimize.patch (text/plain), 612 bytes.

[21 Jun 2023 13:14] alex xing

a simple patch to describe the optimization

(*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: optimize.patch (text/plain), 612 bytes.

[21 Jun 2023 13:56] MySQL Verification Team

Hi Mr. xing,

Thank you for your performance improvement report.

However, we thank you even more for your contribution.

Verified as reported.

[22 Jun 2023 6:29] Tor Didriksen

Posted by developer:
 
The code affected was replaced by something else by the patch for
    BUG#33588473: Binlog compression breaks when compressed size exceeds 1 GiB [step 2]
in MySQL 8.0.34

So the provided patch is no longer relevant.

[22 Jun 2023 12:37] MySQL Verification Team

Thank you, Tor.