| Bug #111276 | There are some punctuation errors here, when buf_flush_do_batch | ||
|---|---|---|---|
| Submitted: | 5 Jun 2023 10:42 | Modified: | 5 Jun 2023 12:00 |
| Reporter: | linkang zhang | Email Updates: | |
| Status: | Verified | Impact on me: | |
| Category: | MySQL Server: InnoDB storage engine | Severity: | S3 (Non-critical) |
| Version: | 8.0, 5.7 | OS: | Any |
| Assigned to: | CPU Architecture: | Any | |
| Tags: | buffer_pool, flush list | ||
[5 Jun 2023 12:00]
MySQL Verification Team
Hello linkang zhang, Thank you for the report and feedback. regards, Umesh
[5 Sep 2023 1:39]
linkang zhang
The bugfix for this bug. (*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.
Contribution: bug_fix.diff (application/octet-stream, text), 609 bytes.
Description: There is some wrong in source code in storage/innobase/buf/buf0flu.cc. How to repeat: diff --git a/storage/innobase/buf/buf0flu.cc b/storage/innobase/buf/buf0flu.cc index facca9efa11..f8883985ef5 100644 --- a/storage/innobase/buf/buf0flu.cc +++ b/storage/innobase/buf/buf0flu.cc @@ -2323,7 +2323,7 @@ static ulint buf_flush_LRU_list(buf_pool_t *buf_pool) { /* Currently one of page_cleaners is the only thread that can trigger an LRU flush at the same time. So, it is not possible that a batch triggered during - last iteration is still running, */ + last iteration is still running */ buf_flush_do_batch(buf_pool, BUF_FLUSH_LRU, scan_depth, 0, &n_flushed); return (n_flushed); Suggested fix: diff --git a/storage/innobase/buf/buf0flu.cc b/storage/innobase/buf/buf0flu.cc index facca9efa11..f8883985ef5 100644 --- a/storage/innobase/buf/buf0flu.cc +++ b/storage/innobase/buf/buf0flu.cc @@ -2323,7 +2323,7 @@ static ulint buf_flush_LRU_list(buf_pool_t *buf_pool) { /* Currently one of page_cleaners is the only thread that can trigger an LRU flush at the same time. So, it is not possible that a batch triggered during - last iteration is still running, */ + last iteration is still running */ buf_flush_do_batch(buf_pool, BUF_FLUSH_LRU, scan_depth, 0, &n_flushed); return (n_flushed);