Bug #110922 Contribution by Tencent: missing --valgrind option in default.daily-valgrind
Submitted: 5 May 2023 8:56 Modified: 11 May 2023 14:38
Reporter: Xiaodong Huang (OCA) Email Updates:
Status: Verified Impact on me:
None 
Category:MySQL Server: Tests Severity:S7 (Test Cases)
Version:8.0.32 OS:Any
Assigned to: CPU Architecture:Any

[5 May 2023 8:56] Xiaodong Huang 
Description:
The default.daily-valgrind under ./mysql-test/collections directory is used to check for memory leaks during runing mtr. But each mysql-test-run.pl command don't have --valgrind relative option in the file.

So, Is this command missing this option relative valgrind?

How to repeat:
As above, check default.daily-valgrind file.
[5 May 2023 9:09] MySQL Verification Team 
Hello Xiaodong,

Thank you for the report and feedback.

regards,
Umesh
[8 May 2023 8:53] Bjørn Munch 
This is intentional, or at least it's not a mistake.

Our integration testing with valgrind (or asan/ubsan) will add the necessary MTR command line options and variable settings to run the tests, so that they can use a standard "collections" file.

The special files for valgrind were added later in order to reduce the amount of tests, as they were taking too long.

It would probably be harmless to add an explicit --valgrind, as it would just be duplicated. But it's not needed and might be confusing. Perhaps a comment in the file would be better.
[11 May 2023 14:38] Xiaodong Huang 
Thanks to Bjørn Munch's reply, I figured it out