MySQL Bugs: #10877: mysqldump should use consistent last line

Bug #10877	mysqldump should use consistent last line
Submitted:	26 May 2005 8:11	Modified:	15 Aug 2006 3:35
Reporter:	Carsten Pedersen	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: mysqldump Command-line Client	Severity:	S4 (Feature request)
Version:		OS:
Assigned to:	Magnus Blåudd	CPU Architecture:	Any

Description:
to enable the dba to check whether a mysqldump file is complete, a line should be added at the end of the dump to mark it complete; something like

-- MySQL dump 10.10 completed on 2005-05-26

How to repeat:
this is a feature request, not a bug

These are actually two new features:
1) end marker comment
2) time stamps

i think both  make sense, just wondering whether timestamps in the file 
header and footer should be enabled by default?

I don't see why not - it's not something that will be parsed by mysql on re-loading, so I don't see how it would break anything.

Added code to print output as requested 

Ex:
-- MySQL dump 10.10 completed Sun Jul 23 20:37:10 2006

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/9463

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/9478

Pushed to 5.0.25

Noted in 5.0.25 changelog.

For a successful dump, mysqldump now writes a SQL comment to the end
of the dump file in the following format:

-- Dump completed on YYYY-MM-DD hh:mm:ss

Merged into 5.1.12

Noted in 5.1.12 changelog.

This new feature broke my source control scripts; I can no longer tell if two dumps are the same content-wise, since the "last modified" line is always different. 

I'd hate to write tools to kill that last line manually. Please include an option to mysqldump to show that last line or not, and disable this new feature by default (for back compat reasons). 

Thanks!
-Alex

Sorry, that is too bad.

This bug has been close, please file a new bug with higher priority referencing this and we will see what can be done.

This just broke my scripts too: I archive & compress database backups, and when data has not changed I used to be able to delete an archived copy. With this, I can no longer trivially tell whether a backup has changed or not. I could not see a bug covering this (don't know if one got logged or not), so I have logged it as bug #29815.

For those who'd like to suppress the dump date in the "-- Dump complete" line, a --skip-dump-date option is available as of MySQL 5.0.52/5.1.23. See Bug#31077.