MySQL Bugs: #108517: Return value of fail

Bug #108517	Return value of fail_block() not get checked
Submitted:	16 Sep 2022 1:53	Modified:	16 Sep 2022 6:03
Reporter:	Li Zhong	Email Updates:
Status:	Verified	Impact on me:	None
Category:	MySQL Server: MyISAM storage engine	Severity:	S3 (Non-critical)
Version:	8.0.21	OS:	Any
Assigned to:		CPU Architecture:	Any

View
Add Comment
Files
Developer
Edit Submission
View Progress Log
Contributions

Description:
In https://github.com/mysql/mysql-server/blob/mysql-cluster-8.0.21/mysys/mf_keycache.cc#L3660, fail_block() could return error code, which is unchecked now.

How to repeat:
We find this by our static analysis tool. The analysis result is checked manually.

Suggested fix:
Add check: DBUG_ASSERT(fail_block(block));

Hello Li Zhong,

Thank you for the report and feedback.

regards,
Umesh