MySQL Bugs: #107583: ACK-related methods and fields in Ha_clone

Bug #107583	ACK-related methods and fields in Ha_clone_cbk are unused
Submitted:	17 Jun 2022 7:00	Modified:	17 Jun 2022 7:45
Reporter:	Laurynas Biveinis (OCA)	Email Updates:
Status:	Verified	Impact on me:	None
Category:	MySQL Server: Clone Plugin	Severity:	S3 (Non-critical)
Version:	8.0.29	OS:	Any
Assigned to:		CPU Architecture:	Any

View
Add Comment
Files
Developer
Edit Submission
View Progress Log
Contributions

Description:
One of the clone callback flags is HA_CLONE_ACK. There are some calls to set_ack() which set it, but there are no calls to is_ack_needed() nor direct checks for HA_CLONE_ACK. Thus the flag appears to be completely unused.

How to repeat:
Code reading

Suggested fix:
Remove HA_CLONE_ACK, is_ack_needed, set_ack from Ha_clone_cbk or implement it.

Hello Laurynas,

Thank you for the report and feedback!

regards,
Umesh