Bug #106643 Contribution: fido2.cmake: Fix darwin build
Submitted: 4 Mar 2022 15:37 Modified: 4 Mar 2022 15:45
Reporter: OCA Admin (OCA) Email Updates:
Status: Verified Impact on me:
None 
Category:MySQL Server: Compiling Severity:S3 (Non-critical)
Version:8.0 OS:Any
Assigned to: CPU Architecture:Any
Tags: Contribution

[4 Mar 2022 15:37] OCA Admin 
Description:
This bug tracks a contribution by wentworth zheng (Github user: aaronjheng) as described in http://github.com/mysql/mysql-server/pull/388

How to repeat:
See description

Suggested fix:
See contribution code attached
[4 Mar 2022 15:37] OCA Admin 
Contribution submitted via Github - fido2.cmake: Fix darwin build 
(*) Contribution by wentworth zheng (Github aaronjheng, mysql-server/pull/388#issuecomment-1058713272): I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: git_patch_863229702.txt (text/plain), 1.12 KiB.
[4 Mar 2022 15:45] MySQL Verification Team 
Hello wentworth zheng,

Thank you for the report and contribution.

regards,
Umesh
[8 Mar 2022 14:36] Tor Didriksen 
Posted by developer:
 
This has been fixed in 8.0.29, as part of the patch for:
Bug #103227 	Building on Mac OS with SSL incorrectly copies SSL libraries

We need version information, so I ended up using otool -L after doing:

MACRO(FIND_SYSTEM_FIDO)
  IF(APPLE)
    SET(CMAKE_REQUIRED_INCLUDES
      "${HOMEBREW_HOME}/include"
      "${HOMEBREW_HOME}/libfido2/include"
      "${HOMEBREW_HOME}/openssl@1.1/include"
      )
  ENDIF()

  CHECK_INCLUDE_FILE(fido.h HAVE_FIDO_H)
  FIND_LIBRARY(FIDO_LIBRARY fido2)
[3 May 2022 9:24] Jheng Aaron 
The latest release works. Nice work!