Bug #106607 add function sql_real_connect parameters
Submitted: 1 Mar 2022 7:04 Modified: 1 Mar 2022 8:47
Reporter: bin wang (OCA) Email Updates:
Status: Duplicate Impact on me:
None 
Category:MySQL Server: Command-line Clients Severity:S3 (Non-critical)
Version: OS:Any
Assigned to: CPU Architecture:Any

[1 Mar 2022 7:04] bin wang
Description:
mysql-8.0.28\client\mysql.cc\sql_real_connect.cc
have a parameter lack of name 
static int sql_real_connect(char *host, char *database, char *user, char *,
                            uint silent) {

How to repeat:
add variable  password in the function   would be better
static int sql_real_connect(char *host, char *database, char *user, char * , uint silent) {
..................
    ret = mysql_real_connect_dns_srv(&mysql, dns_srv_name, user, nullptr,
                                     database,
                                     connect_flag | CLIENT_MULTI_STATEMENTS);
..................
    ret = mysql_real_connect(&mysql, host, user, nullptr, database,
                             opt_mysql_port, opt_mysql_unix_port,
                             connect_flag | CLIENT_MULTI_STATEMENTS);
..................

Suggested fix:
+static int sql_real_connect(char *host, char *database, char *user, char *password,
                             uint silent) {
   if (connected) {
     connected = false;
@@ -4525,11 +4525,11 @@ static int sql_real_connect(char *host,
 #endif
   MYSQL *ret;
   if (dns_srv_name)
-    ret = mysql_real_connect_dns_srv(&mysql, dns_srv_name, user, nullptr,
+    ret = mysql_real_connect_dns_srv(&mysql, dns_srv_name, user, passeord,
                                      database,
                                      connect_flag | CLIENT_MULTI_STATEMENTS);
   else
-    ret = mysql_real_connect(&mysql, host, user, nullptr, database,
+    ret = mysql_real_connect(&mysql, host, user, password, database,
                              opt_mysql_port, opt_mysql_unix_port,
                              connect_flag | CLIENT_MULTI_STATEMENTS);
   if (!ret) {
[1 Mar 2022 7:04] bin wang
suggested add  patch

Attachment: mysql.patch (application/octet-stream, text), 1.13 KiB.

[1 Mar 2022 8:30] MySQL Verification Team
Hello bin wang,

Please do not submit the same bug more than once. Your earlier reported Bug #106606 already describes this very problem. Even if you feel that your issue is somewhat different, the resolution is likely
to be the same. Because of this, we hope you add your comments to the original bug instead.

Thank you for your interest in MySQL.

regards,
Umesh
[1 Mar 2022 8:47] bin wang
mysql-8.0.28\client\mysql.cc\sql_real_connect.cc
have a parameter lack of name 
static int sql_real_connect(char *host, char *database, char *user, char *,
                            uint silent) {