Description:
there are some typo.
--- a/sql/handler.h
+++ b/sql/handler.h
@@ -5283,8 +5283,8 @@ class handler {
transactions to release their locks on a given row before we can read it and
potentially update it. However, in READ UNCOMMITTED and READ COMMITTED, we
can ignore these locks if we don't intend to modify the row (e.g., because
- it failed a WHERE). This is signaled through enabling “semi-consistent
- read”, by calling try_semi_consistent_read(true) (and then setting it back
+ it failed a WHERE). This is signaled through enabling "semi-consistent
+ read", by calling try_semi_consistent_read(true) (and then setting it back
to false after finishing the query).
If semi-consistent read is enabled, and we are in READ UNCOMMITTED or READ
--- a/sql/field.cc
+++ b/sql/field.cc
@@ -6315,7 +6315,7 @@ size_t Field_string::make_sort_key(uchar *to, size_t length) const {
points, which is not allowed.
The min() is because charpos() is allowed to return a value past
- the end of the string for “end of string”.
+ the end of the string for "end of string".
*/
size_t input_length = std::min<size_t>(
field_length,
@@ -7700,6 +7700,12 @@ type_conversion_status Field_json::store(const Field_json *field) {
return store_binary(s->ptr(), s->length());
}
--- a/sql/item.h
+++ b/sql/item.h
@@ -2024,7 +2052,7 @@ class Item : public Parse_tree_node {
/**
If this Item is being materialized into a temporary table, returns the
field that is being materialized into. (Typically, this is the
- “result_field” members for items that have one.)
+ "result_field" members for items that have one.)
*/
virtual Field *get_tmp_table_field() {
How to repeat:
see the code
Description: there are some typo. --- a/sql/handler.h +++ b/sql/handler.h @@ -5283,8 +5283,8 @@ class handler { transactions to release their locks on a given row before we can read it and potentially update it. However, in READ UNCOMMITTED and READ COMMITTED, we can ignore these locks if we don't intend to modify the row (e.g., because - it failed a WHERE). This is signaled through enabling “semi-consistent - read”, by calling try_semi_consistent_read(true) (and then setting it back + it failed a WHERE). This is signaled through enabling "semi-consistent + read", by calling try_semi_consistent_read(true) (and then setting it back to false after finishing the query). If semi-consistent read is enabled, and we are in READ UNCOMMITTED or READ --- a/sql/field.cc +++ b/sql/field.cc @@ -6315,7 +6315,7 @@ size_t Field_string::make_sort_key(uchar *to, size_t length) const { points, which is not allowed. The min() is because charpos() is allowed to return a value past - the end of the string for “end of string”. + the end of the string for "end of string". */ size_t input_length = std::min<size_t>( field_length, @@ -7700,6 +7700,12 @@ type_conversion_status Field_json::store(const Field_json *field) { return store_binary(s->ptr(), s->length()); } --- a/sql/item.h +++ b/sql/item.h @@ -2024,7 +2052,7 @@ class Item : public Parse_tree_node { /** If this Item is being materialized into a temporary table, returns the field that is being materialized into. (Typically, this is the - “result_field” members for items that have one.) + "result_field" members for items that have one.) */ virtual Field *get_tmp_table_field() { How to repeat: see the code