Bug #101366 In ib_sdi_flush(), parameter space_id does not get used at all

• Submitted: 29 Oct 2020 7:31
• Modified: 29 Oct 2020 12:41
• Reporter: Li Zhong
• Status: Verified
• Category: MySQL Server: InnoDB storage engine
• Severity: S4 (Feature request)
• Version: 8.0
• OS: Any
• CPU Architecture: Any

[29 Oct 2020 7:31] Li Zhong

Description:
In storage/innobase/api/api0api.cc, ib_sdi_flush(), parameter space_id does not get used at all. It's as follows:

/** Flush SDI in a tablespace. The pages of a SDI Index modified by the
transaction will be flushed to disk.
@param[in]      space_id        tablespace id
@return DB_SUCCESS always */
ib_err_t ib_sdi_flush(space_id_t space_id) { return (DB_SUCCESS); }

If space_id is truly not necessary here, I suggest it should be add with attribute MY_ATTRIBUTE(unused).

How to repeat:
In source code of mysql-8.0.21

[29 Oct 2020 12:41] MySQL Verification Team

Hi Mr. Zhong,

Thank you for your bug report.

It does make sense to make it noted as unused, since this function used to have even more parameters.

Verified as reported, but with a lower severity, due to the lack of impact.

[29 Oct 2020 12:42] MySQL Verification Team

Just setting a version.