MySQL Bugs: #61160: When closing query window

Bug #61160	When closing query window - need to add confirmation
Submitted:	13 May 2011 7:40	Modified:	2 Sep 2011 6:44
Reporter:	Ilya Cheburaev	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Workbench: SQL Editor	Severity:	S4 (Feature request)
Version:	5.2.33	OS:	Any
Assigned to:		CPU Architecture:	Any

Description:
When closing query window - there is no confirmation

How to repeat:
Create new query window write a big query and just press to close icon - it will close even if you did it accidentally
I've wrot a big query and wanted to close another query but closed this one and it closed then i've to rewrite it again.

Suggested fix:
Just add confirmation before closing query (close without saving) like in MSSQL SQL Editor.

to reproduce this - just open 2 query windows - then swith to first and when switching - press on the plase where close (X) icon have to appear - it will close query windows - i've got this situation - after writing sql query i've switched to another one and when switched back i clicked on the area of X icon and it closed (even if X icond were hidden before click)

it's better to add confirmation or to skip clicking on X area if X icon is hidden

Version is 5.2.33CE rev 7508

I'd say this is a bug. Verified on Windows XP.

Duplicate of bug #61037

Not actually a duplicate of the above bug.

Fixed as of 5.2.35:

+        Under certain circumstances, closing a query window would not
+        prompt to save the query.

This bug still exists for me using 5.2.35-pre22 in OS X Lion (v10.7.1) :(

Steps to repeat:

1. Open Workbench 5.2.35-pre22
2. Connect to database
3. Type something in the initial tab (e.g. SHOW PROCESSLIST )
4. Create New Tab (Command + T)
5. Press the 1st tab's "close" button ("X" icon)
-----
6. Watch as the first tab gets closed with no confirmation, deleting your initial query.

Mike

The initial tab is a "scratch" tab, which is meant for temporary queries not meant to be saved. Once you save the contents of that tab, the tab becomes a normal script tab. Closing those will ask for confirmation, if there's something unsaved.

Alfredo,

Thank you for the clarification on the "scratch tab". It's something I have never seen in any other query editor, and admittedly is quite unclear and somewhat confusing. IMHO, the goal should aim to prevent ANY loss of work (by default), but keeping the "scratch tab" around as an option for those who know they may never want/need their queries saved (accidental or not)...

One other observation (at least on OS X):

I attempted closing a connection with multiple open tabs (10+ tabs), each of them full of SQL, but I did not receive a single prompt confirming if I wanted to close the tab vs. keeping it open to save the SQL.

Coupled with this bug #60253 (http://bugs.mysql.com/bug.php?id=60253) this leads to the unfortunate side affect of trying to close the current tab you're on, but having the entire connection closed instead -- potentially losing any open tabs'  SQL along with it...