| Bug #57912 | Use memset() rather than the deprecated bfill() and bzero() | ||
|---|---|---|---|
| Submitted: | 2 Nov 2010 6:42 | Modified: | 3 Jun 2011 1:50 |
| Reporter: | Tor Didriksen | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: General | Severity: | S3 (Non-critical) |
| Version: | 5.1+ | OS: | Any |
| Assigned to: | Tor Didriksen | CPU Architecture: | Any |
[20 Jan 2011 13:59]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/129281 3538 Tor Didriksen 2011-01-20 Bug #57912 Use memset() rather than the deprecated bfill() and bzero() @ support-files/build-tags Extend filter to tag .cpp files as well.
[3 Jun 2011 1:50]
Paul DuBois
No user impact. No changelog entry needed.
Description: The following suggestion was accepted unanimously by the coding style committee meeting on oct 27: I suggest we remove this recommendation from the style guide: For example, use |bfill()| and |bzero()| instead of |memset()|. and that we use the standard memset() function. reason: bzero has a number of problems - bzero does not seem to be well defined, I'm getting this during MySQL configure on Fedora release 12 config.log:conftest.c:247: warning: conflicting types for built-in function 'bzero' - on some platforms it is not defined - on some platforms it is available, but in non-standard places - it was deprecated by posix 9 years ago - it is not part of the current posix standard - http://bugs.mysql.com/bug.php?id=55721 where autoconf finds bzero() but the prototype is not visible when compiling, do the build fails Implementation strategy: replace bfill() and bzero() with memset(), merge changes into relevant trees. How to repeat: See description.