Bug #89646 Clang warnings in 5.7.21

• Submitted: 13 Feb 2018 10:28
• Modified: 7 Sep 2018 8:38
• Reporter: Zsolt Parragi (OCA)
• Status: Won't fix
• Category: MySQL Server: Compiling
• Severity: S3 (Non-critical)
• Version: 5.7.21
• OS: Ubuntu (clang 5.0)
• CPU Architecture: Any
• Tags: Contribution

[13 Feb 2018 10:28] Zsolt Parragi

Description:
* There are unnecessary parentheses in sql/partitioning/partition_handler.cc at a condition
* There is a unused global variable in 
rapid/plugin/group_replication/src/sql_service/sql_service_interface.cc, command_name.

How to repeat:
Compile mysql with clang

[13 Feb 2018 10:28] Zsolt Parragi

Removal of two warnings reported by clang

(*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: clang-fix.patch (text/x-patch), 2.62 KiB.

[13 Feb 2018 10:29] Zsolt Parragi

Removal of two warnings reported by clang

(*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: clang-fix.patch (text/x-patch), 2.62 KiB.

[13 Feb 2018 10:37] MySQL Verification Team

Hello Zsolt Parragi,

Thank you for the report and contribution.

Thanks,
Umesh

[7 Sep 2018 8:38] Dyre Tjeldvoll

Posted by developer:
 
We aim to be warning free with gcc and clang, and try to fix them as they appear. Typically when upgrading the compiler. Normally we fix only on trunk.
This particular issue is fixed in 8.0 and up.