Bug #77226 Target sql_embedded should depend on GenDigestServerSource
Submitted: 2 Jun 2015 14:52 Modified: 3 Jan 2019 11:33
Reporter: Sergei Glushchenko Email Updates:
Status: Won't fix Impact on me:
None 
Category:MySQL Server: Compiling Severity:S3 (Non-critical)
Version:5.6.24 OS:Any
Assigned to: CPU Architecture:Any

[2 Jun 2015 14:52] Sergei Glushchenko
Description:
Source file 'sql_yacc.yy' needs generated file 'lex_token.h'. This file is generated by 'GenDigestServerSource', which is dependency for 'sql', but not for 'sql_embedded'. One cannot see it normally, but if you disable 'sql' and leave only 'sql_embedded' by editing 'CMakeLists.txt' you will get compile error.

How to repeat:
Check 'sql/CMakeLists.txt' and 'libmysqld/CMakeLists.txt'.

Suggested fix:
--- i/libmysqld/CMakeLists.txt
+++ w/libmysqld/CMakeLists.txt
@@ -81,7 +81,7 @@ SET(SQL_EMBEDDED_SOURCES

 ADD_CONVENIENCE_LIBRARY(sql_embedded ${SQL_EMBEDDED_SOURCES})
 DTRACE_INSTRUMENT(sql_embedded)
-ADD_DEPENDENCIES(sql_embedded GenError GenServerSource)
+ADD_DEPENDENCIES(sql_embedded GenError GenServerSource GenDigestServerSource)

 # On Windows, static embedded server library is called mysqlserver.lib
 # On Unix, it is libmysqld.a
[3 Jun 2015 6:16] MySQL Verification Team
Hello Sergei,

Thank you for the report and contribution.

Thanks,
Umesh
[20 Nov 2018 9:19] Dyre Tjeldvoll
Posted by developer:
 
Thank you for bringing this to our attention! But as you may know, we have decided to remove the embedded server in 8.0 so the change is no longer needed there. And since we do not normally backport such fixes to GA releases, we have to close this bug.