Bug #65408 fails to build when directory contains a '+'

• Submitted: 24 May 2012 6:06
• Modified: 8 Mar 2013 6:34
• Reporter: Nicholas Bamber (OCA)
• Status: Won't fix
• Category: MySQL Server: Compiling
• Severity: S3 (Non-critical)
• Version: 5.5.26
• OS: Any
• CPU Architecture: Any
• Tags: Compilation, path, regex

[24 May 2012 6:06] Nicholas Bamber

Description:
When the full path of the build directory contains a '+' certain tests fail. This is because MYSQL_CHARSETSDIR ends up being interpreted as a regular expression.

How to repeat:
Build in any directory containing a '+' in the full path.

Suggested fix:
I have an attached patch.

[25 May 2012 8:14] Valeriy Kravchuk

What exact server version, 5.x.y, you are talking about? What exact tests failed in your case.

I've just built 5.5.26 in "mysql+5.5" subdirectory on 64-bit FC14, and "make test" worked OK, mtr still runs...

P.S. I do not see any patch attached

[25 May 2012 10:17] Valeriy Kravchuk

Got test failure. main.mysqld--help-notwin test failed on 64-bit FC14. This is a bug.

[25 May 2012 20:15] Nicholas Bamber

Yes that's it and also one other. My patch is at http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=12;filename=regex_plus.patch;att=1;bug=67.... I was going to upload it but I have not got through the contributer agreement process yet.

[1 Jun 2012 20:28] Nicholas Bamber

I have now signed the OCA. Yey!

[14 Jun 2012 10:26] Nicholas Bamber

make the test include fragment backslash '+'; should probably be more thorough

(*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: regex_plus.patch (text/x-patch), 1.12 KiB.

[7 Mar 2013 15:59] Ståle Deraas

Hi Nicholas,

The build is not failing in 5.6, so we are not going to use your contribution. 

Thank you,
Staale