Bug #58871 Reorganize maintainer mode compiler flags to allow option for specific compilers

• Submitted: 10 Dec 2010 16:31
• Modified: 22 Dec 2010 19:09
• Reporter: Davi Arnaut (OCA)
• Status: Closed
• Category: MySQL Server: Compiling
• Severity: S3 (Non-critical)
• Version: 5.5
• OS: Any
• Assigned to: Davi Arnaut
• CPU Architecture: Any

[10 Dec 2010 16:31] Davi Arnaut

Description:
Ideally, the maintainer mode should be able to use different warning options depending on the compiler being used. Compiling the source code with strict warnings from different compilers allows for a wider range of compile time checks.

How to repeat:
Compile MySQL with the maintainer mode enabled with a compiler other than GCC.

Suggested fix:
Initially, it would be nice to detect and enable a couple of flags for ICC.

[13 Dec 2010 17:36] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/126697

3188 Davi Arnaut	2010-12-13
      Bug#58871: Reorganize maintainer mode compiler flags to allow
                 option for specific compilers
      
      Reorganize the maintainer mode cmake code to allow options
      for specific compilers. For now, enable -Wall for ICC, but
      do not turn warnings into errors.
     @ CMakeLists.txt
        Move the code that sets options to cmake/maintainer.cmake
     @ cmake/maintainer.cmake
        Add macros for each specific compiler.

[14 Dec 2010 12:43] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/126755

3188 Davi Arnaut	2010-12-14
      Bug#58871: Reorganize maintainer mode compiler flags to allow
                 option for specific compilers
      
      Reorganize the maintainer mode cmake code to allow options
      for specific compilers. For now, enable -Wall for ICC, but
      do not turn warnings into errors.
     @ CMakeLists.txt
        Move the code that sets options to cmake/maintainer.cmake
     @ cmake/maintainer.cmake
        Add macros for each specific compiler.

[14 Dec 2010 16:16] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/126803

3188 Davi Arnaut	2010-12-14
      Bug#58871: Reorganize maintainer mode compiler flags to allow
                 option for specific compilers
      
      Reorganize the maintainer mode cmake code to allow options
      for specific compilers. For now, enable -Wall for ICC, but
      do not turn warnings into errors.
     @ CMakeLists.txt
        Move the code that sets options to cmake/maintainer.cmake
     @ cmake/maintainer.cmake
        Add macros for each specific compiler.

[15 Dec 2010 10:30] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/126903

3196 Davi Arnaut	2010-12-15
      Bug#58871: Reorganize maintainer mode compiler flags to allow
                 option for specific compilers
      
      Reorganize the maintainer mode cmake code to allow options
      for specific compilers. For now, enable -Wcheck for ICC,
      but do not turn warnings into errors.
     @ CMakeLists.txt
        Move the code that sets options to cmake/maintainer.cmake
     @ cmake/maintainer.cmake
        Add macros for each specific compiler.

[15 Dec 2010 23:21] Davi Arnaut

Queued to mysql-5.5-bugteam and up.

[17 Dec 2010 12:50] Bugs System

Pushed into mysql-5.5 5.5.9 (revid:[e-mail]-20101217124733-p1ivu6higouawv8l) (version source revid:[e-mail]-20101215103009-m8bow30bi2463uy8) (merge vers: 5.5.8) (pib:24)

[17 Dec 2010 12:55] Bugs System

Pushed into mysql-trunk 5.6.1 (revid:[e-mail]-20101217125013-y8pb3az32rtbplc9) (version source revid:[e-mail]-20101215231037-swrblumh9rj3sj5i) (merge vers: 5.6.1) (pib:24)

[22 Dec 2010 19:09] Paul DuBois

Noted in 5.5.9 changelog.

Configuration with maintainer mode enabled resulted in errors when
compiling with icc.