MySQL Bugs: #55846: Link tests fail on Windows

Bug #55846	Link tests fail on Windows - my_compiler.h missing
Submitted:	9 Aug 2010 15:57	Modified:	10 Jan 2013 11:11
Reporter:	Karen Langford	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server	Severity:	S3 (Non-critical)
Version:	5.1.50, 5.5.6-m3, 5.6.0-m4	OS:	Any
Assigned to:	Assigned Account	CPU Architecture:	Any
Tags:	my_global.h

Description:
On Windows, all "linktest" runs failed, because "my_global.h" wants
to include "my_compiler.h" which isn't found.

Seems "scripts/make_win_bin_dist" wasn't adapted in the changeset which introduced this file (a security fix). The changeset that caused this 
problem dealt with bug#42733.

FYI Joerg suggested that this bug be classified as security bug (because the error is in a security fix), not sure how that is done though.

How to repeat:
Build 5.1.50 on windows platform.

Suggested fix:
We updated scripts/make_win_bin_dist, added in my_compiler.h and 
rebuilt. Problem went away.

The missing my_compiler.h affects Unix systems as well, for example when compiling PHP with the MySQLi extension, it has a #include <my_global.h>, which in turn tries to #include <my_compiler.h>, but it is missing from the installation.

Suggested fix for Unix-type systems

Attachment: 5.1.50_include_missing_my_compiler_h.patch (application/octet-stream, text), 960 bytes.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/116644

3489 Davi Arnaut	2010-08-24
      Bug#55846: Link tests fail on Windows - my_compiler.h missing
      
      Make the my_compiler.h header, like my_attribute.h, part of
      the distribution. This is required due to the dependency of
      the former on the latter (which can undefine __attribute__).

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/117264

3186 Davi Arnaut	2010-08-31
      Bug#55846: Link tests fail on Windows - my_compiler.h missing
      
      Make the my_compiler.h header, like my_attribute.h, part of
      the distribution. This is required due to the dependency of
      the former on the latter (which can undefine __attribute__).

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/117266

3087 Alexander Nozdrin	2010-08-31
      Cherry-picking patch for Bug#55846.
      Original changeset:
      ------------------------------------------------------------
      revno: 3186
      revision-id: davi.arnaut@oracle.com-20100831142822-2qhufn3hho4xqr4p
      parent: gshchepa@mysql.com-20100830222201-ie7n43mjy4irlllk
      committer: Davi Arnaut <davi.arnaut@oracle.com>
      branch nick: mysql-5.5-merge
      timestamp: Tue 2010-08-31 11:28:22 -0300
      message:
        Bug#55846: Link tests fail on Windows - my_compiler.h missing
        
        Make the my_compiler.h header, like my_attribute.h, part of
        the distribution. This is required due to the dependency of
        the former on the latter (which can undefine __attribute__).
      ------------------------------------------------------------

Last patch was pushed to mysql-5.1-bugteam and up.

Pushed into mysql-5.5 5.5.7-rc (revid:joerg@mysql.com-20100910184813-csdto6tk4nlogrsq) (version source revid:joerg@mysql.com-20100910184813-csdto6tk4nlogrsq) (merge vers: 5.5.7-rc) (pib:21)

Pushed into mysql-trunk 5.6.1-m4 (revid:dlenev@mysql.com-20100913103627-p2oqplu42x1gv2bd) (version source revid:dlenev@mysql.com-20100913102657-ye9uwx05td7h2q3o) (merge vers: 5.6.1-m4) (pib:21)

Pushed into mysql-next-mr (revid:dlenev@mysql.com-20100913121556-sfxqlpj9kbc28kaf) (version source revid:dlenev@mysql.com-20100913121556-sfxqlpj9kbc28kaf) (pib:21)

Pushed into mysql-5.1 5.1.52 (revid:sunanda.menon@sun.com-20100928083322-wangbv97uobu7g66) (version source revid:sunanda.menon@sun.com-20100928083322-wangbv97uobu7g66) (merge vers: 5.1.52) (pib:21)

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@sun.com-20100928153607-tdsxkdm5cmuym5sq) (version source revid:alik@sun.com-20100928153508-0saa6v93dinqx1u7) (merge vers: 5.6.1-m4) (pib:21)

Pushed into mysql-next-mr (revid:alik@sun.com-20100928153646-pqp8o1a92mxtuj3h) (version source revid:alik@sun.com-20100928153532-lr3gtvnyp2en4y75) (pib:21)

Pushed into mysql-5.5 5.5.7-rc (revid:alik@sun.com-20100928153459-4nudf4zgzlou4s7q) (version source revid:alik@sun.com-20100928153459-4nudf4zgzlou4s7q) (merge vers: 5.5.7-rc) (pib:21)

Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:martin.skold@mysql.com-20101014082627-jrmy9xbfbtrebw3c) (version source revid:martin.skold@mysql.com-20101014082627-jrmy9xbfbtrebw3c) (merge vers: 5.1.51-ndb-7.0.20) (pib:21)

Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:martin.skold@mysql.com-20101014083757-5qo48b86d69zjvzj) (version source revid:martin.skold@mysql.com-20101014083757-5qo48b86d69zjvzj) (merge vers: 5.1.51-ndb-6.3.39) (pib:21)

Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:martin.skold@mysql.com-20101014084420-y54ecj85j5we27oa) (version source revid:martin.skold@mysql.com-20101014084420-y54ecj85j5we27oa) (merge vers: 5.1.51-ndb-6.2.19) (pib:21)

Fixed in 5.1.51