Bug #55658 gen_lex_hash bug on documentation

• Submitted: 31 Jul 2010 8:19
• Modified: 13 Nov 2010 16:53
• Reporter: Claudio Eterno
• Status: Closed
• Category: MySQL Server: Parser
• Severity: S3 (Non-critical)
• Version: 5.1, all
• OS: Any
• Assigned to: Marc ALFF
• CPU Architecture: Any

[31 Jul 2010 8:19] Claudio Eterno

Description:
Very simple question. No problem on code. I was reading gen_lex_hash.cc.
I think that:

mysql-5.1.49/sql/gen_lex_hash.cc at line 48 col 20

Intead of 'b' said char should be 'd'

for this structure, presented program generate next searching-structure:

Line 1 to 50:
+-----------+-+-+-+
|       len |1|2|3|
+-----------+-+-+-+
|first_char |0|0|a|
|last_char  |0|0|d|
|link       |0|0|+|
                 |
                 V
       +----------+-+-+-+--+
       |    1 char|a|b|c|d |
       +----------+-+-+-+--+
       |first_char|b|0|0|0 |
       |last_char |n|0|0|-1|
       |link      |+|0|0|+ |
 

How to repeat:
It's only a documentation problem

Suggested fix:
                 |
                 V
       +----------+-+-+-+--+
       |    1 char|a|b|c|d |
       +----------+-+-+-+--+
       |first_char|'d'|0|0|0 |

Intead of 'b' said char should be 'd'

[2 Aug 2010 10:34] Sveta Smirnova

Thank you for the report.

Verified as described.

[26 Aug 2010 15:36] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/116916

3252 Marc Alff	2010-08-26
      Bug#55658 gen_lex_hash bug on documentation
      
      Fixed a typo in the code comments.
      
      The proper character in the data described is 'd',
      because it corresponds to the second letter of the ADD symbol.

[26 Aug 2010 15:42] Marc ALFF

Approved by Paul on IRC

[26 Aug 2010 15:51] Marc ALFF

pushed into:
- mysql-next-mr-bugfixing (5.6.99)

Doc team:
no user visible effect, nothing to document.

[30 Aug 2010 8:36] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100830082745-n6sh01wlwh3itasv) (version source revid:[e-mail]-20100830082745-n6sh01wlwh3itasv) (pib:21)

[13 Nov 2010 16:08] Bugs System

Pushed into mysql-trunk 5.6.99-m5 (revid:[e-mail]-20101113155825-czmva9kg4n31anmu) (version source revid:[e-mail]-20100629074804-359l9m9gniauxr94) (merge vers: 5.6.99-m4) (pib:21)

[13 Nov 2010 16:53] Paul DuBois

Cosmetic change. No changelog entry needed.